From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F01AC433F5 for ; Mon, 18 Apr 2022 21:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbiDRVhj (ORCPT ); Mon, 18 Apr 2022 17:37:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbiDRVhh (ORCPT ); Mon, 18 Apr 2022 17:37:37 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 72FB5655C; Mon, 18 Apr 2022 14:34:57 -0700 (PDT) Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 482EB2034C72; Mon, 18 Apr 2022 14:34:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 482EB2034C72 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1650317697; bh=vj0lnOdsk0bHFr5EZlPrXDBc40yXZt3qOC1HHQtuVGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NyyLuiJ0VoRVuAIRC2aoUJ2gtQHHauWDD/gmDJcRNyEvsAl3rD5zEPKVCKdznx+WP /PFgtpmyoDfsnCWG6x5WkBIe8W06JLcSj4O/w0ByAxZf2DcEBEG/WAdyPyLKU5A+do 3py4Q2MusGAI33EDBQQbXFSlU4RdqHHUBRR8xX78= Date: Mon, 18 Apr 2022 16:34:53 -0500 From: Tyler Hicks To: Borislav Petkov Cc: Greg Kroah-Hartman , Sasha Levin , Lei Wang , Tony Luck , Mauro Carvalho Chehab , Sinan Kaya , Shiping Ji , James Morse , Robert Richter , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC/dmc520: Don't print an error for each unconfigured interrupt line Message-ID: <20220418213453.GB31854@sequoia> References: <20220118152816.GA89184@sequoia> <20220118195401.GB89184@sequoia> <20220404215640.GA626436@sequoia> <20220418204029.GA31854@sequoia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-04-18 23:13:36, Borislav Petkov wrote: > On Mon, Apr 18, 2022 at 03:40:29PM -0500, Tyler Hicks wrote: > > > The API argument seems to have fizzled out in v2: > > > > > > https://lore.kernel.org/lkml/20220212201631.12648-1-s.shtylyov@omp.ru/ > > I don't see those two upstream yet, on a quick glance. Perhaps in Greg's tree? > > Greg, what's the latest with that platform_get_*_optional() fun? > > Also, the second of those two patches above has: > > + * Return: non-zero IRQ number on success, 0 if IRQ wasn't found, negative error > + * number on failure. > */ > int platform_get_irq_byname_optional(struct platform_device *dev, > > and your patch does: > > + irq = platform_get_irq_byname_optional(pdev, dmc520_irq_configs[idx].name); > irqs[idx] = irq; > > so on failure, it would still write the negative error value in > irqs[idx]. > > How can that be right? The patches to modify the API have become stale. There have been no new comments or revisions since Feb. What I'm proposing is to proceed with merging this simple fix and let the folks discussing the API changes adjust the use in the dmc250 driver if/when they decide to revive the API changes. Tyler > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette >