public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>,
	Manish Rangankar <mrangankar@marvell.com>,
	Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Sasha Levin <sashal@kernel.org>,
	jejb@linux.ibm.com, open-iscsi@googlegroups.com,
	linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 5.15 17/27] scsi: iscsi: Move iscsi_ep_disconnect()
Date: Tue, 19 Apr 2022 14:12:32 -0400	[thread overview]
Message-ID: <20220419181242.485308-17-sashal@kernel.org> (raw)
In-Reply-To: <20220419181242.485308-1-sashal@kernel.org>

From: Mike Christie <michael.christie@oracle.com>

[ Upstream commit c34f95e98d8fb750eefd4f3fe58b4f8b5e89253b ]

This patch moves iscsi_ep_disconnect() so it can be called earlier in the
next patch.

Link: https://lore.kernel.org/r/20220408001314.5014-2-michael.christie@oracle.com
Tested-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Reviewed-by: Chris Leech <cleech@redhat.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/scsi/scsi_transport_iscsi.c | 38 ++++++++++++++---------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 554b6f784223..126f6f23bffa 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -2236,6 +2236,25 @@ static void iscsi_stop_conn(struct iscsi_cls_conn *conn, int flag)
 	ISCSI_DBG_TRANS_CONN(conn, "Stopping conn done.\n");
 }
 
+static void iscsi_ep_disconnect(struct iscsi_cls_conn *conn, bool is_active)
+{
+	struct iscsi_cls_session *session = iscsi_conn_to_session(conn);
+	struct iscsi_endpoint *ep;
+
+	ISCSI_DBG_TRANS_CONN(conn, "disconnect ep.\n");
+	conn->state = ISCSI_CONN_FAILED;
+
+	if (!conn->ep || !session->transport->ep_disconnect)
+		return;
+
+	ep = conn->ep;
+	conn->ep = NULL;
+
+	session->transport->unbind_conn(conn, is_active);
+	session->transport->ep_disconnect(ep);
+	ISCSI_DBG_TRANS_CONN(conn, "disconnect ep done.\n");
+}
+
 static int iscsi_if_stop_conn(struct iscsi_transport *transport,
 			      struct iscsi_uevent *ev)
 {
@@ -2276,25 +2295,6 @@ static int iscsi_if_stop_conn(struct iscsi_transport *transport,
 	return 0;
 }
 
-static void iscsi_ep_disconnect(struct iscsi_cls_conn *conn, bool is_active)
-{
-	struct iscsi_cls_session *session = iscsi_conn_to_session(conn);
-	struct iscsi_endpoint *ep;
-
-	ISCSI_DBG_TRANS_CONN(conn, "disconnect ep.\n");
-	conn->state = ISCSI_CONN_FAILED;
-
-	if (!conn->ep || !session->transport->ep_disconnect)
-		return;
-
-	ep = conn->ep;
-	conn->ep = NULL;
-
-	session->transport->unbind_conn(conn, is_active);
-	session->transport->ep_disconnect(ep);
-	ISCSI_DBG_TRANS_CONN(conn, "disconnect ep done.\n");
-}
-
 static void iscsi_cleanup_conn_work_fn(struct work_struct *work)
 {
 	struct iscsi_cls_conn *conn = container_of(work, struct iscsi_cls_conn,
-- 
2.35.1


  parent reply	other threads:[~2022-04-19 18:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 18:12 [PATCH AUTOSEL 5.15 01/27] ARM: vexpress/spc: Avoid negative array index when !SMP Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 02/27] reset: renesas: Check return value of reset_control_deassert() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 03/27] reset: tegra-bpmp: Restore Handle errors in BPMP response Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 04/27] platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 05/27] ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 06/27] drm/msm/disp: check the return value of kzalloc() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 07/27] arm64: dts: imx: Fix imx8*-var-som touchscreen property sizes Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 08/27] vxlan: fix error return code in vxlan_fdb_append Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 09/27] cifs: Check the IOCB_DIRECT flag, not O_DIRECT Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 10/27] net: atlantic: Avoid out-of-bounds indexing Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 11/27] mt76: Fix undefined behavior due to shift overflowing the constant Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 12/27] brcmfmac: sdio: " Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 13/27] dpaa_eth: Fix missing of_node_put in dpaa_get_ts_info() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 14/27] drm/msm/mdp5: check the return of kzalloc() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 15/27] drm/msm: Stop using iommu_present() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 16/27] net: macb: Restart tx only if queue pointer is lagging Sasha Levin
2022-04-19 18:12 ` Sasha Levin [this message]
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 18/27] scsi: iscsi: Fix offload conn cleanup when iscsid restarts Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 19/27] scsi: iscsi: Release endpoint ID when its freed Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 20/27] scsi: iscsi: Merge suspend fields Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 21/27] scsi: iscsi: Fix NOP handling during conn recovery Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 22/27] scsi: qedi: Fix failed disconnect handling Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 23/27] stat: fix inconsistency between struct stat and struct compat_stat Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 24/27] VFS: filename_create(): fix incorrect intent Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 25/27] nvme: add a quirk to disable namespace identifiers Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 26/27] nvme-pci: disable namespace identifiers for the MAXIO MAP1002/1202 Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 27/27] nvme-pci: disable namespace identifiers for Qemu controllers Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220419181242.485308-17-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=cleech@redhat.com \
    --cc=jejb@linux.ibm.com \
    --cc=lduncan@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=mrangankar@marvell.com \
    --cc=open-iscsi@googlegroups.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox