From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 5.15 02/27] reset: renesas: Check return value of reset_control_deassert()
Date: Tue, 19 Apr 2022 14:12:17 -0400 [thread overview]
Message-ID: <20220419181242.485308-2-sashal@kernel.org> (raw)
In-Reply-To: <20220419181242.485308-1-sashal@kernel.org>
From: Heiner Kallweit <hkallweit1@gmail.com>
[ Upstream commit da18980a855edf44270f05455e0ec3f2472f64cc ]
Deasserting the reset is vital, therefore bail out in case of error.
Suggested-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/b2131908-0110-006b-862f-080517f3e2d8@gmail.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
index 1e8315038850..a8dde4606360 100644
--- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
+++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
@@ -121,7 +121,9 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev)
return dev_err_probe(dev, PTR_ERR(priv->rstc),
"failed to get reset\n");
- reset_control_deassert(priv->rstc);
+ error = reset_control_deassert(priv->rstc);
+ if (error)
+ return error;
priv->rcdev.ops = &rzg2l_usbphy_ctrl_reset_ops;
priv->rcdev.of_reset_n_cells = 1;
--
2.35.1
next prev parent reply other threads:[~2022-04-19 18:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 18:12 [PATCH AUTOSEL 5.15 01/27] ARM: vexpress/spc: Avoid negative array index when !SMP Sasha Levin
2022-04-19 18:12 ` Sasha Levin [this message]
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 03/27] reset: tegra-bpmp: Restore Handle errors in BPMP response Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 04/27] platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 05/27] ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 06/27] drm/msm/disp: check the return value of kzalloc() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 07/27] arm64: dts: imx: Fix imx8*-var-som touchscreen property sizes Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 08/27] vxlan: fix error return code in vxlan_fdb_append Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 09/27] cifs: Check the IOCB_DIRECT flag, not O_DIRECT Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 10/27] net: atlantic: Avoid out-of-bounds indexing Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 11/27] mt76: Fix undefined behavior due to shift overflowing the constant Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 12/27] brcmfmac: sdio: " Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 13/27] dpaa_eth: Fix missing of_node_put in dpaa_get_ts_info() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 14/27] drm/msm/mdp5: check the return of kzalloc() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 15/27] drm/msm: Stop using iommu_present() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 16/27] net: macb: Restart tx only if queue pointer is lagging Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 17/27] scsi: iscsi: Move iscsi_ep_disconnect() Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 18/27] scsi: iscsi: Fix offload conn cleanup when iscsid restarts Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 19/27] scsi: iscsi: Release endpoint ID when its freed Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 20/27] scsi: iscsi: Merge suspend fields Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 21/27] scsi: iscsi: Fix NOP handling during conn recovery Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 22/27] scsi: qedi: Fix failed disconnect handling Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 23/27] stat: fix inconsistency between struct stat and struct compat_stat Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 24/27] VFS: filename_create(): fix incorrect intent Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 25/27] nvme: add a quirk to disable namespace identifiers Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 26/27] nvme-pci: disable namespace identifiers for the MAXIO MAP1002/1202 Sasha Levin
2022-04-19 18:12 ` [PATCH AUTOSEL 5.15 27/27] nvme-pci: disable namespace identifiers for Qemu controllers Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419181242.485308-2-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox