From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3ADAC433F5 for ; Tue, 19 Apr 2022 18:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357271AbiDSS14 (ORCPT ); Tue, 19 Apr 2022 14:27:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357425AbiDSSXU (ORCPT ); Tue, 19 Apr 2022 14:23:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E5A243EC6; Tue, 19 Apr 2022 11:16:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 19AA5B81185; Tue, 19 Apr 2022 18:16:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 541FFC385A7; Tue, 19 Apr 2022 18:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650392162; bh=kKCNAiRVSRYNBM3a+Hb6jDO/M8J2VQLjQI3FjTMlN74=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=liORUwxZt3UbrEPErKtHpUTNsGPlCRUWMe7f/UR8I9OlN3NwXUParR3Ttxd/69r4M AI7Mz7ETgJCjjSuzBJcAoJJegjonwB1CPc/UXGXvLW34V3/rFB6l42MHXv7ffd7mjZ +jHHy+nIzM+p7f4nJwtFGdJxDZ/OEb/yKKRU2LJXfJc4smsd4bYg47B8rkVnv/DqOS IlSqn82fhqMgJKQBDoxCUgM3ZE+XfpQPFw2BkkmloQvZ6c7lJQ0YRNCVtTmq/7TWlN edq7u1vzfei6MiTnuntrgt2eSsmOyFqXToCE7iOyD674ePJZ9o/QXDQv15nDk4RtbS Wk5ID9Ls9b9IA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiapeng Chong , Abaci Robot , Hans de Goede , Sasha Levin , corentin.chary@gmail.com, markgross@kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 2/9] platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative Date: Tue, 19 Apr 2022 14:15:50 -0400 Message-Id: <20220419181557.486336-2-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220419181557.486336-1-sashal@kernel.org> References: <20220419181557.486336-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit 0284d4d1be753f648f28b77bdfbe6a959212af5c ] Eliminate the follow smatch warnings: drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: unsigned 'value' is never less than zero. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Link: https://lore.kernel.org/r/20220322061830.105579-1-jiapeng.chong@linux.alibaba.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Sasha Levin --- drivers/platform/x86/samsung-laptop.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c index d3cb26f6df73..c1c34b495519 100644 --- a/drivers/platform/x86/samsung-laptop.c +++ b/drivers/platform/x86/samsung-laptop.c @@ -1125,8 +1125,6 @@ static void kbd_led_set(struct led_classdev *led_cdev, if (value > samsung->kbd_led.max_brightness) value = samsung->kbd_led.max_brightness; - else if (value < 0) - value = 0; samsung->kbd_led_wk = value; queue_work(samsung->led_workqueue, &samsung->kbd_led_work); -- 2.35.1