Re: [PATCH 14/25] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor

Manivannan Sadhasivam
2022-03-24T18:14:40Z

On Thu, Mar 24, 2022 at 04:48:25AM +0300, Serge Semin wrote:
> The rest of the locally defined and used methods and structures have
> dw_edma prefix in their names. It's right in accordance with the kernel
> coding style to follow the locally defined rule of naming. Let's add that
> prefix to the debugfs_entries structure too especially seeing it's name
> may be confusing as if that structure belongs to the global DebugFS space.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Man

> ---
> drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> index 808eed212be8..afd519d9568b 100644
> --- a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> @@ -46,7 +46,7 @@ static struct {
> void __iomem *end;
> } lim[2][EDMA_V0_MAX_NR_CH];
>
> -struct debugfs_entries {
> +struct dw_edma_debugfs_entry {
> const char *name;
> void __iomem *reg;
> };
> @@ -94,7 +94,7 @@ static int dw_edma_debugfs_u32_get(void *data, u64 *val)
> }
> DEFINE_DEBUGFS_ATTRIBUTE(fops_x32, dw_edma_debugfs_u32_get, NULL, "0x%08llx\n");
>
> -static void dw_edma_debugfs_create_x32(const struct debugfs_entries entries[],
> +static void dw_edma_debugfs_create_x32(const struct dw_edma_debugfs_entry entries[],
> int nr_entries, struct dentry *dir)
> {
> int i;
> @@ -108,8 +108,7 @@ static void dw_edma_debugfs_create_x32(const struct debugfs_entries entries[],
> static void dw_edma_debugfs_regs_ch(struct dw_edma_v0_ch_regs __iomem *regs,
> struct dentry *dir)
> {
> - int nr_entries;
> - const struct debugfs_entries debugfs_regs[] = {
> + const struct dw_edma_debugfs_entry debugfs_regs[] = {
> REGISTER(ch_control1),
> REGISTER(ch_control2),
> REGISTER(transfer_size),
> @@ -120,6 +119,7 @@ static void dw_edma_debugfs_regs_ch(struct dw_edma_v0_ch_regs __iomem *regs,
> REGISTER(llp.lsb),
> REGISTER(llp.msb),
> };
> + int nr_entries;
>
> nr_entries = ARRAY_SIZE(debugfs_regs);
> dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, dir);
> @@ -127,7 +127,7 @@ static void dw_edma_debugfs_regs_ch(struct dw_edma_v0_ch_regs __iomem *regs,
>
> static void dw_edma_debugfs_regs_wr(struct dentry *dir)
> {
> - const struct debugfs_entries debugfs_regs[] = {
> + const struct dw_edma_debugfs_entry debugfs_regs[] = {
> /* eDMA global registers */
> WR_REGISTER(engine_en),
> WR_REGISTER(doorbell),
> @@ -148,7 +148,7 @@ static void dw_edma_debugfs_regs_wr(struct dentry *dir)
> WR_REGISTER(ch67_imwr_data),
> WR_REGISTER(linked_list_err_en),
> };
> - const struct debugfs_entries debugfs_unroll_regs[] = {
> + const struct dw_edma_debugfs_entry debugfs_unroll_regs[] = {
> /* eDMA channel context grouping */
> WR_REGISTER_UNROLL(engine_chgroup),
> WR_REGISTER_UNROLL(engine_hshake_cnt.lsb),
> @@ -191,7 +191,7 @@ static void dw_edma_debugfs_regs_wr(struct dentry *dir)
>
> static void dw_edma_debugfs_regs_rd(struct dentry *dir)
> {
> - const struct debugfs_entries debugfs_regs[] = {
> + const struct dw_edma_debugfs_entry debugfs_regs[] = {
> /* eDMA global registers */
> RD_REGISTER(engine_en),
> RD_REGISTER(doorbell),
> @@ -213,7 +213,7 @@ static void dw_edma_debugfs_regs_rd(struct dentry *dir)
> RD_REGISTER(ch45_imwr_data),
> RD_REGISTER(ch67_imwr_data),
> };
> - const struct debugfs_entries debugfs_unroll_regs[] = {
> + const struct dw_edma_debugfs_entry debugfs_unroll_regs[] = {
> /* eDMA channel context grouping */
> RD_REGISTER_UNROLL(engine_chgroup),
> RD_REGISTER_UNROLL(engine_hshake_cnt.lsb),
> @@ -256,7 +256,7 @@ static void dw_edma_debugfs_regs_rd(struct dentry *dir)
>
> static void dw_edma_debugfs_regs(void)
> {
> - const struct debugfs_entries debugfs_regs[] = {
> + const struct dw_edma_debugfs_entry debugfs_regs[] = {
> REGISTER(ctrl_data_arb_prior),
> REGISTER(ctrl),
> };
> --
> 2.35.1
>