From: Pingfan Liu <kernelfans@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Pingfan Liu <kernelfans@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Qais Yousef <qais.yousef@arm.com>,
Yuan ZhaoXiong <yuanzhaoxiong@baidu.com>,
Randy Dunlap <rdunlap@infradead.org>,
Dongli Zhang <dongli.zhang@oracle.com>,
YueHaibing <yuehaibing@huawei.com>,
Steven Price <steven.price@arm.com>
Subject: [PATCH 9/9] irq/irqdesc: rename sparse_irq_lock to bitmap_lock
Date: Wed, 20 Apr 2022 22:05:21 +0800 [thread overview]
Message-ID: <20220420140521.45361-10-kernelfans@gmail.com> (raw)
In-Reply-To: <20220420140521.45361-1-kernelfans@gmail.com>
Now that sparse_irq_lock serves for both sparse and non-sparse purpose,
it is better to rename it as bitmap_lock. Corresponding, rename
irq_lock_sparse() as irq_lock_bitmap().
Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Pingfan Liu <kernelfans@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Oleksandr Natalenko <oleksandr@natalenko.name>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Valentin Schneider <valentin.schneider@arm.com>
Cc: Qais Yousef <qais.yousef@arm.com>
Cc: Yuan ZhaoXiong <yuanzhaoxiong@baidu.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Dongli Zhang <dongli.zhang@oracle.com>
Cc: YueHaibing <yuehaibing@huawei.com>
Cc: Steven Price <steven.price@arm.com>
To: linux-kernel@vger.kernel.org
---
include/linux/irqdesc.h | 4 ++--
kernel/cpu.c | 4 ++--
kernel/irq/cpuhotplug.c | 4 ++--
kernel/irq/debugfs.c | 4 ++--
kernel/irq/irqdesc.c | 26 +++++++++++++-------------
kernel/irq/pm.c | 4 ++--
6 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h
index 6c01231fec00..8301653fc2b2 100644
--- a/include/linux/irqdesc.h
+++ b/include/linux/irqdesc.h
@@ -104,8 +104,8 @@ struct irq_desc {
const char *name;
} ____cacheline_internodealigned_in_smp;
-extern void irq_lock_sparse(void);
-extern void irq_unlock_sparse(void);
+extern void irq_lock_bitmap(void);
+extern void irq_unlock_bitmap(void);
#ifndef CONFIG_SPARSE_IRQ
extern struct irq_desc irq_desc[NR_IRQS];
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 94a6b512c26d..8874f0242893 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -601,11 +601,11 @@ static int bringup_cpu(unsigned int cpu)
* setup the vector space for the cpu which comes online.
* Prevent irq alloc/free across the bringup.
*/
- irq_lock_sparse();
+ irq_lock_bitmap();
/* Arch-specific enabling code. */
ret = __cpu_up(cpu, idle);
- irq_unlock_sparse();
+ irq_unlock_bitmap();
if (ret)
return ret;
return bringup_wait_for_ap(cpu);
diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
index 1ed2b1739363..84547b5781be 100644
--- a/kernel/irq/cpuhotplug.c
+++ b/kernel/irq/cpuhotplug.c
@@ -220,14 +220,14 @@ int irq_affinity_online_cpu(unsigned int cpu)
struct irq_desc *desc;
unsigned int irq;
- irq_lock_sparse();
+ irq_lock_bitmap();
for_each_active_irq(irq) {
desc = irq_to_desc(irq);
raw_spin_lock_irq(&desc->lock);
irq_restore_affinity_of_irq(desc, cpu);
raw_spin_unlock_irq(&desc->lock);
}
- irq_unlock_sparse();
+ irq_unlock_bitmap();
return 0;
}
diff --git a/kernel/irq/debugfs.c b/kernel/irq/debugfs.c
index 2b43f5f5033d..af4bd2ca2372 100644
--- a/kernel/irq/debugfs.c
+++ b/kernel/irq/debugfs.c
@@ -251,10 +251,10 @@ static int __init irq_debugfs_init(void)
irq_dir = debugfs_create_dir("irqs", root_dir);
- irq_lock_sparse();
+ irq_lock_bitmap();
for_each_active_irq(irq)
irq_add_debugfs_entry(irq, irq_to_desc(irq));
- irq_unlock_sparse();
+ irq_unlock_bitmap();
return 0;
}
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index a5cefd7c9ef7..acd80cb8a511 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -130,7 +130,7 @@ static void desc_set_defaults(unsigned int irq, struct irq_desc *desc, int node,
int nr_irqs = NR_IRQS;
EXPORT_SYMBOL_GPL(nr_irqs);
-static DEFINE_MUTEX(sparse_irq_lock);
+static DEFINE_MUTEX(bitmap_lock);
static DECLARE_BITMAP(allocated_irqs, IRQ_BITMAP_BITS);
#ifdef CONFIG_SPARSE_IRQ
@@ -318,12 +318,12 @@ static int __init irq_sysfs_init(void)
}
/* Prevent concurrent irq alloc/free */
- irq_lock_sparse();
+ irq_lock_bitmap();
/* Add the already allocated interrupts */
for_each_irq_desc(irq, desc)
irq_sysfs_add(irq, desc);
- irq_unlock_sparse();
+ irq_unlock_bitmap();
return 0;
}
@@ -607,9 +607,9 @@ static int irq_expand_nr_irqs(unsigned int nr)
void irq_mark_irq(unsigned int irq)
{
- mutex_lock(&sparse_irq_lock);
+ mutex_lock(&bitmap_lock);
bitmap_set(allocated_irqs, irq, 1);
- mutex_unlock(&sparse_irq_lock);
+ mutex_unlock(&bitmap_lock);
}
#ifdef CONFIG_GENERIC_IRQ_LEGACY
@@ -711,14 +711,14 @@ int generic_handle_domain_nmi(struct irq_domain *domain, unsigned int hwirq)
}
#endif
-void irq_lock_sparse(void)
+void irq_lock_bitmap(void)
{
- mutex_lock(&sparse_irq_lock);
+ mutex_lock(&bitmap_lock);
}
-void irq_unlock_sparse(void)
+void irq_unlock_bitmap(void)
{
- mutex_unlock(&sparse_irq_lock);
+ mutex_unlock(&bitmap_lock);
}
/* Dynamic interrupt handling */
@@ -735,12 +735,12 @@ void irq_free_descs(unsigned int from, unsigned int cnt)
if (from >= nr_irqs || (from + cnt) > nr_irqs)
return;
- mutex_lock(&sparse_irq_lock);
+ mutex_lock(&bitmap_lock);
for (i = 0; i < cnt; i++)
free_desc(from + i);
bitmap_clear(allocated_irqs, from, cnt);
- mutex_unlock(&sparse_irq_lock);
+ mutex_unlock(&bitmap_lock);
}
EXPORT_SYMBOL_GPL(irq_free_descs);
@@ -779,7 +779,7 @@ __irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node,
from = arch_dynirq_lower_bound(from);
}
- mutex_lock(&sparse_irq_lock);
+ mutex_lock(&bitmap_lock);
start = bitmap_find_next_zero_area(allocated_irqs, IRQ_BITMAP_BITS,
from, cnt, 0);
@@ -794,7 +794,7 @@ __irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node,
}
ret = alloc_descs(start, cnt, node, affinity, owner);
unlock:
- mutex_unlock(&sparse_irq_lock);
+ mutex_unlock(&bitmap_lock);
return ret;
}
EXPORT_SYMBOL_GPL(__irq_alloc_descs);
diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index 4b67a4c7de3c..9b81a738d84f 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -133,7 +133,7 @@ void suspend_device_irqs(void)
struct irq_desc *desc;
int irq;
- irq_lock_sparse();
+ irq_lock_bitmap();
for_each_irq_desc(irq, desc) {
unsigned long flags;
bool sync;
@@ -147,7 +147,7 @@ void suspend_device_irqs(void)
if (sync)
synchronize_irq(irq);
}
- irq_unlock_sparse();
+ irq_unlock_bitmap();
}
EXPORT_SYMBOL_GPL(suspend_device_irqs);
--
2.31.1
prev parent reply other threads:[~2022-04-20 14:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:05 [PATCH 0/9] trival fix or improvement about irq_desc access Pingfan Liu
2022-04-20 14:05 ` [PATCH 1/9] irq/irqdesc: put the lock at the exact place in irq_sysfs_init() Pingfan Liu
2022-04-20 14:05 ` [PATCH 2/9] irq/irqdesc: change the name of delete_irq_desc() to irq_delete_desc() Pingfan Liu
2022-04-20 14:05 ` [PATCH 3/9] irq/manage: remove some unreferenced code Pingfan Liu
2022-04-20 20:56 ` Miguel Ojeda
2022-04-20 14:05 ` [PATCH 4/9] s390/irq: utilize RCU instead of irq_lock_sparse() in show_msi_interrupt() Pingfan Liu
2022-04-20 18:16 ` Heiko Carstens
2022-04-21 3:36 ` Pingfan Liu
2022-04-21 11:42 ` Heiko Carstens
2022-04-22 9:56 ` Pingfan Liu
2022-04-22 10:02 ` [PATCHv2] " Pingfan Liu
2022-04-25 11:39 ` Heiko Carstens
2022-04-20 14:05 ` [PATCH 5/9] x86/irq: place for_each_active_irq() in rcu read section Pingfan Liu
2022-04-20 14:05 ` [PATCH 6/9] pm/irq: make for_each_irq_desc() safe of irq_desc release Pingfan Liu
2022-04-20 16:23 ` Rafael J. Wysocki
2022-04-21 3:31 ` Pingfan Liu
2022-04-21 10:57 ` Rafael J. Wysocki
2022-04-22 10:43 ` Pingfan Liu
2022-04-27 6:03 ` [PATCHv2] genirq/PM: Make " Pingfan Liu
2022-04-20 14:05 ` [PATCH 7/9] irq: remove needless lock in takedown_cpu() Pingfan Liu
2022-04-21 16:11 ` Thomas Gleixner
2022-04-25 2:57 ` Pingfan Liu
2022-04-25 9:43 ` Thomas Gleixner
2022-04-27 6:01 ` Pingfan Liu
2022-04-20 14:05 ` [PATCH 8/9] irq: make irq_lock_sparse() independent of CONFIG_SPARSE_IRQ Pingfan Liu
2022-04-20 14:05 ` Pingfan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420140521.45361-10-kernelfans@gmail.com \
--to=kernelfans@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=dongli.zhang@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oleksandr@natalenko.name \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=rdunlap@infradead.org \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=yuanzhaoxiong@baidu.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox