From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C041CC433F5 for ; Thu, 21 Apr 2022 08:10:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386522AbiDUIN2 (ORCPT ); Thu, 21 Apr 2022 04:13:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386513AbiDUIMu (ORCPT ); Thu, 21 Apr 2022 04:12:50 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B35C2BE9 for ; Thu, 21 Apr 2022 01:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650528600; x=1682064600; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cLE6xmcyejVNPvTSv0CwIrdK3A7MUJeex/f7C9SJaSE=; b=jcmW1boO6Ivks8xfR+u6BTjuEnPr6f4Qo4UOXd6Rux/KVZigyh0f6ub0 +1naLcGNVtxpJWiwGd6KEbiSKOuz+3zaLMaH5VLKu3c7+WkADhvKiesgQ c4vVq/BigreXNjdqjVCmibLrzM7p38rv8RsO9M15hdlqljv6cS5RsKQ9m PfHdDyI8/PEg6TQavxv2s9JPa328tYVuCWwdVh3PGpoqwW0vMi1eOf3+0 fXtYNSEihQ7lE9NJxlYmprH/4RDl1ndZPaq2J3Ol5oLomLE4WeIhN5Ppm 2hOSQxxV40pMIDdTadhm8NgQ52tHjVjvm/YNPD5NfRLLfNifLtMF0fbml g==; X-IronPort-AV: E=McAfee;i="6400,9594,10323"; a="244857080" X-IronPort-AV: E=Sophos;i="5.90,278,1643702400"; d="scan'208";a="244857080" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 01:10:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,278,1643702400"; d="scan'208";a="614783287" Received: from lkp-server01.sh.intel.com (HELO 3abc53900bec) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 21 Apr 2022 01:09:58 -0700 Received: from kbuild by 3abc53900bec with local (Exim 4.95) (envelope-from ) id 1nhRt0-00086k-7D; Thu, 21 Apr 2022 08:09:58 +0000 Date: Thu, 21 Apr 2022 16:09:48 +0800 From: kernel test robot To: Haowen Bai , Greg Kroah-Hartman Cc: kbuild-all@lists.01.org, Haowen Bai , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp() Message-ID: <202204211558.TapLZO4j-lkp@intel.com> References: <1650504854-17576-1-git-send-email-baihaowen@meizu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1650504854-17576-1-git-send-email-baihaowen@meizu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Haowen, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.18-rc3] [also build test ERROR on next-20220421] [cannot apply to staging/staging-testing] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Haowen-Bai/staging-rtl8192e-Fix-signedness-bug-in-rtllib_rx_assoc_resp/20220421-093531 base: b2d229d4ddb17db541098b83524d901257e93845 config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220421/202204211558.TapLZO4j-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/e1395cdafd4dea7a368f2d9599832636035a03d2 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Haowen-Bai/staging-rtl8192e-Fix-signedness-bug-in-rtllib_rx_assoc_resp/20220421-093531 git checkout e1395cdafd4dea7a368f2d9599832636035a03d2 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/staging/rtl8192e/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/staging/rtl8192e/rtllib_softmac.c: In function 'auth_parse': >> drivers/staging/rtl8192e/rtllib_softmac.c:1792:29: error: 'ieee' undeclared (first use in this function) 1792 | netdev_info(ieee->dev, "auth_parse() failed"); | ^~~~ drivers/staging/rtl8192e/rtllib_softmac.c:1792:29: note: each undeclared identifier is reported only once for each function it appears in vim +/ieee +1792 drivers/staging/rtl8192e/rtllib_softmac.c 1766 1767 static inline int auth_parse(struct net_device *dev, struct sk_buff *skb, 1768 u8 **challenge, int *chlen) 1769 { 1770 struct rtllib_authentication *a; 1771 u8 *t; 1772 1773 if (skb->len < (sizeof(struct rtllib_authentication) - 1774 sizeof(struct rtllib_info_element))) { 1775 netdev_dbg(dev, "invalid len in auth resp: %d\n", skb->len); 1776 return -EINVAL; 1777 } 1778 *challenge = NULL; 1779 a = (struct rtllib_authentication *) skb->data; 1780 if (skb->len > (sizeof(struct rtllib_authentication) + 3)) { 1781 t = skb->data + sizeof(struct rtllib_authentication); 1782 1783 if (*(t++) == MFIE_TYPE_CHALLENGE) { 1784 *chlen = *(t++); 1785 *challenge = kmemdup(t, *chlen, GFP_ATOMIC); 1786 if (!*challenge) 1787 return -ENOMEM; 1788 } 1789 } 1790 1791 if (a->status) { > 1792 netdev_info(ieee->dev, "auth_parse() failed"); 1793 return -EINVAL; 1794 } 1795 1796 return 0; 1797 } 1798 -- 0-DAY CI Kernel Test Service https://01.org/lkp