From: Russ Weight <russell.h.weight@intel.com>
To: mcgrof@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org,
linux-kernel@vger.kernel.org
Cc: trix@redhat.com, marpagan@redhat.com, lgoncalv@redhat.com,
yilun.xu@intel.com, hao.wu@intel.com,
matthew.gerlach@linux.intel.com,
basheer.ahmed.muddebihal@intel.com, tianfei.zhang@intel.com,
Russ Weight <russell.h.weight@intel.com>
Subject: [PATCH v5 1/8] firmware_loader: Clear data and size in fw_free_paged_buf
Date: Thu, 21 Apr 2022 14:21:57 -0700 [thread overview]
Message-ID: <20220421212204.36052-2-russell.h.weight@intel.com> (raw)
In-Reply-To: <20220421212204.36052-1-russell.h.weight@intel.com>
The fw_free_paged_buf() function resets the paged buffer information in
the fw_priv data structure. Additionally, clear the data and size members
of fw_priv in order to facilitate the reuse of fw_priv. This is being
done in preparation for enabling userspace to initiate multiple firmware
uploads using this sysfs interface.
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Tianfei zhang <tianfei.zhang@intel.com>
Tested-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Signed-off-by: Russ Weight <russell.h.weight@intel.com>
---
v1:
- No change from RFC patch
v2:
- No change
v3:
- Added Reviewed-by tag
v4:
- Added Reviewed-by tag
v5:
- Added Tested-by tag
---
drivers/base/firmware_loader/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index 94d1789a233e..2cc11d93753a 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -253,6 +253,8 @@ void fw_free_paged_buf(struct fw_priv *fw_priv)
fw_priv->pages = NULL;
fw_priv->page_array_size = 0;
fw_priv->nr_pages = 0;
+ fw_priv->data = NULL;
+ fw_priv->size = 0;
}
int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed)
--
2.25.1
next prev parent reply other threads:[~2022-04-21 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 21:21 [PATCH v5 0/8] Extend FW framework for user FW uploads Russ Weight
2022-04-21 21:21 ` Russ Weight [this message]
2022-04-21 21:21 ` [PATCH v5 2/8] firmware_loader: Check fw_state_is_done in loading_store Russ Weight
2022-04-21 21:21 ` [PATCH v5 3/8] firmware_loader: Split sysfs support from fallback Russ Weight
2022-04-21 21:22 ` [PATCH v5 4/8] firmware_loader: Add firmware-upload support Russ Weight
2022-04-21 21:22 ` [PATCH v5 5/8] firmware_loader: Add sysfs nodes to monitor fw_upload Russ Weight
2022-04-21 21:22 ` [PATCH v5 6/8] test_firmware: Add test support for firmware upload Russ Weight
2022-04-21 21:22 ` [PATCH v5 7/8] test_firmware: Error injection " Russ Weight
2022-04-21 21:22 ` [PATCH v5 8/8] selftests: firmware: Add firmware upload selftests Russ Weight
2022-04-26 10:36 ` Greg KH
2022-04-27 18:03 ` Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421212204.36052-2-russell.h.weight@intel.com \
--to=russell.h.weight@intel.com \
--cc=basheer.ahmed.muddebihal@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox