From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84D0C433F5 for ; Fri, 22 Apr 2022 02:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443626AbiDVC4L (ORCPT ); Thu, 21 Apr 2022 22:56:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443621AbiDVC4J (ORCPT ); Thu, 21 Apr 2022 22:56:09 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59E044D636 for ; Thu, 21 Apr 2022 19:53:17 -0700 (PDT) X-UUID: 272af0c95c334f2ab44e2ac5451820dc-20220422 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:e9307f85-12c3-4783-86c5-0857a376cb9c,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:53,FILE:0,RULE:Release_Ham,ACT ION:release,TS:53 X-CID-INFO: VERSION:1.1.4,REQID:e9307f85-12c3-4783-86c5-0857a376cb9c,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:53,FILE:0,RULE:Release_UHam,ACTI ON:release,TS:53 X-CID-META: VersionHash:faefae9,CLOUDID:363b8cf0-da02-41b4-b6df-58f4ccd36682,C OID:3120d0ac20a5,Recheck:0,SF:13|15|28|16|19|48,TC:nil,Content:0,EDM:-3,Fi le:nil,QS:0,BEC:nil X-UUID: 272af0c95c334f2ab44e2ac5451820dc-20220422 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1478556448; Fri, 22 Apr 2022 10:53:13 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Fri, 22 Apr 2022 10:53:12 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 22 Apr 2022 10:53:12 +0800 From: Miles Chen To: CC: , , , , , , , , Subject: Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used Date: Fri, 22 Apr 2022 10:53:12 +0800 Message-ID: <20220422025312.7718-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Taksshi, >> We observed: 'dmasound_setup' defined but not used error with >> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build. >> >> Fix it by adding __maybe_unused to dmasound_setup. >> >> Error(s): >> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function] >> >> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m") >> Signed-off-by: Miles Chen >> Cc: Takashi Iwai > >Thanks, applied. This patch is needed in 5.18-rc3 [1] too, should I submit another patch or you can pick it to the mainstream? [1] https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2204190925230.302265@ramsan.of.borg/ thanks, Miles > > >Takashi