Re: [PATCH] topology: Fix up build warning in topology_is_visible()

Greg Kroah-Hartman
2022-04-23T10:53:12Z

On Fri, Apr 22, 2022 at 08:26:53AM +0200, Greg Kroah-Hartman wrote:
> Commit aa63a74d4535 ("topology/sysfs: Hide PPIN on systems that do not
> support it.") caused a build warning on some configurations:
>
> drivers/base/topology.c: In function 'topology_is_visible':
> drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
> 158 | struct device *dev = kobj_to_dev(kobj);
>
> Fix this up by getting rid of the variable entirely.
>
> Fixes: aa63a74d4535 ("topology/sysfs: Hide PPIN on systems that do not support it.")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/base/topology.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/base/topology.c b/drivers/base/topology.c
> index 706dbf8bf249..ac6ad9ab67f9 100644
> --- a/drivers/base/topology.c
> +++ b/drivers/base/topology.c
> @@ -155,9 +155,7 @@ static struct attribute *default_attrs[] = {
> static umode_t topology_is_visible(struct kobject *kobj,
> struct attribute *attr, int unused)
> {
> - struct device *dev = kobj_to_dev(kobj);
> -
> - if (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id))
> + if (attr == &dev_attr_ppin.attr && !topology_ppin(kobj_to_dev(kobj)->id))
> return 0;
>
> return attr->mode;
> --
> 2.36.0
>

Given no comments that this is a bad idea, I'll go apply this now.

thanks,

greg k-h