From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
Date: Fri, 22 Apr 2022 10:00:54 +1000 [thread overview]
Message-ID: <20220422100054.74cadded@canb.auug.org.au> (raw)
In-Reply-To: <90d0e2c9b4a74c92bcdd5fc4313a7629@intel.com>
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
Hi Tony,
On Thu, 21 Apr 2022 23:38:28 +0000 "Luck, Tony" <tony.luck@intel.com> wrote:
>
> >> Fixes: c3702a746ff5 ("topology/sysfs: Hide PPIN on systems that do not support it.")
> >
> > This is actually commit aa63a74d4535.
>
> Doh! I looked in my tree, not in Greg's.
>
> Doesn't matter much, Greg is going to revert as I haven't come up with a good[1]
> way to fix this.
>
> -Tony
>
> [1] I found two bad ways. First one made Greg barf. This one breaks the build for over
> 50% of supported architectures :-(
I assume that there is some good reason that topology_ppin() is not
implemented as a static inline function?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-22 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 5:26 linux-next: build warning after merge of the driver-core.current tree Stephen Rothwell
2022-04-21 6:49 ` Greg KH
2022-04-21 15:45 ` [PATCH] topology/sysfs: Fix allnoconfig build breakage Luck, Tony
2022-04-21 15:53 ` Greg KH
2022-04-21 16:19 ` [PATCH v2] " Luck, Tony
2022-04-21 23:22 ` Stephen Rothwell
2022-04-21 23:38 ` Luck, Tony
2022-04-22 0:00 ` Stephen Rothwell [this message]
2022-04-22 2:51 ` Luck, Tony
2022-04-22 6:00 ` Greg KH
2022-04-22 6:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422100054.74cadded@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox