From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Hridya Valsaraju" <hridya@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Ira Weiny" <ira.weiny@intel.com>,
linux-kernel@vger.kernel.org
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Subject: [PATCH 3/3] binder: Use kmap_local_page() in binder_alloc_get_page()
Date: Sat, 23 Apr 2022 12:24:21 +0200 [thread overview]
Message-ID: <20220423102421.16869-4-fmdefrancesco@gmail.com> (raw)
In-Reply-To: <20220423102421.16869-1-fmdefrancesco@gmail.com>
The use of kmap_atomic() is being deprecated in favor of kmap_local_page()
where it is feasible. Each call of kmap_atomic() in the kernel creates
a non-preemptible section and disable pagefaults. This could be a source
of unwanted latency, so it should be only used if it is absolutely
required, otherwise kmap_local_page() should be preferred.
With kmap_local_page(), the mapping is per thread, CPU local and not
globally visible. Furthermore, the mapping can be acquired from any context
(including interrupts).
Therefore, use kmap_local_page() / kunmap_local() in place of
kmap_atomic() / kunmap_atomic().
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
drivers/android/binder_alloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
index 0875c463c002..058595cc7ff0 100644
--- a/drivers/android/binder_alloc.c
+++ b/drivers/android/binder_alloc.c
@@ -1250,17 +1250,17 @@ static int binder_alloc_do_buffer_copy(struct binder_alloc *alloc,
page = binder_alloc_get_page(alloc, buffer,
buffer_offset, &pgoff);
size = min_t(size_t, bytes, PAGE_SIZE - pgoff);
- base_ptr = kmap_atomic(page);
+ base_ptr = kmap_local_page(page);
tmpptr = base_ptr + pgoff;
if (to_buffer)
memcpy(tmpptr, ptr, size);
else
memcpy(ptr, tmpptr, size);
/*
- * kunmap_atomic() takes care of flushing the cache
+ * kunmap_local() takes care of flushing the cache
* if this device has VIVT cache arch
*/
- kunmap_atomic(base_ptr);
+ kunmap_local(base_ptr);
bytes -= size;
pgoff = 0;
ptr = ptr + size;
--
2.34.1
next prev parent reply other threads:[~2022-04-23 10:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 10:24 [PATCH 0/3] binder: Use kmap_local_page() in binder_alloc.c Fabio M. De Francesco
2022-04-23 10:24 ` [PATCH 1/3] binder: Use memset_page() in binder_alloc_clear_buf() Fabio M. De Francesco
2022-04-23 15:43 ` Todd Kjos
2022-04-23 10:24 ` [PATCH 2/3] binder: Use kmap_local_page() in binder_alloc_copy_user_to_buffer() Fabio M. De Francesco
2022-04-23 15:43 ` Todd Kjos
2022-04-23 10:24 ` Fabio M. De Francesco [this message]
2022-04-23 15:44 ` [PATCH 3/3] binder: Use kmap_local_page() in binder_alloc_get_page() Todd Kjos
2022-04-23 16:02 ` Christophe JAILLET
2022-04-23 16:02 ` Christophe JAILLET
2022-04-24 9:39 ` Fabio M. De Francesco
2022-04-25 15:52 ` Todd Kjos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423102421.16869-4-fmdefrancesco@gmail.com \
--to=fmdefrancesco@gmail.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=ira.weiny@intel.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox