From: Manivannan Sadhasivam <mani@kernel.org>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: quic_hemantk@quicinc.com, quic_bbhatt@quicinc.com,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] MHI MMIO register write updates
Date: Sat, 23 Apr 2022 18:56:20 +0530 [thread overview]
Message-ID: <20220423132620.GO374560@thinkpad> (raw)
In-Reply-To: <1650304226-11080-1-git-send-email-quic_jhugo@quicinc.com>
On Mon, Apr 18, 2022 at 11:50:24AM -0600, Jeffrey Hugo wrote:
> In case of MHI MMIO writes, the register field write function needs to do reads
> before writes are performed. Propagate read failures such that callers are made
> aware of those and can take appropriate action instead of running blind.
>
> Optimizing the MMIO initialization function to use mhi_write_reg() in most cases
> should also be done to improve design.
>
> These patches were tested on X86_64 architecture with Ubuntu 18.04 and SDX65
> attach.
>
> v4:
> Address review comments about log messages, and a missing blank line
>
> v3:
> Noticed this was reviewed but never picked up. Rebased to -next
>
> v2:
> -Fix testbot reported missing set of changes from pm.c
>
> Bhaumik Bhatt (2):
> bus: mhi: host: Bail on writing register fields if read fails
> bus: mhi: host: Optimize and update MMIO register write method
Series applied to mhi-next!
Thanks,
Mani
>
> drivers/bus/mhi/host/boot.c | 22 +++++++++----
> drivers/bus/mhi/host/init.c | 68 ++++++++++++++++++++++++-----------------
> drivers/bus/mhi/host/internal.h | 7 +++--
> drivers/bus/mhi/host/main.c | 9 ++++--
> drivers/bus/mhi/host/pm.c | 15 ++++++---
> 5 files changed, 77 insertions(+), 44 deletions(-)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2022-04-23 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 17:50 [PATCH v4 0/2] MHI MMIO register write updates Jeffrey Hugo
2022-04-18 17:50 ` [PATCH v4 1/2] bus: mhi: host: Bail on writing register fields if read fails Jeffrey Hugo
2022-04-23 12:26 ` Manivannan Sadhasivam
2022-04-18 17:50 ` [PATCH v4 2/2] bus: mhi: host: Optimize and update MMIO register write method Jeffrey Hugo
2022-04-23 13:26 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423132620.GO374560@thinkpad \
--to=mani@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_bbhatt@quicinc.com \
--cc=quic_hemantk@quicinc.com \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox