Re: [PATCH V2] xhci-plat: Let usb phy shutdown later

surong pang
2022-04-29T01:55:07Z

Dear Greg,
Sorry for html email response.
Yes, The subject should say "xhci-plat". And it didn't fix a specific commit id.

surong pang <surong.pang@gmail.com> 于2022年4月28日周四 14:26写道：
>
> Dear Greg,
> No, It's just a patch to call usb_phy_shutdown later.
>
>
> Greg KH <gregkh@linuxfoundation.org> 于2022年4月26日周二 19:53写道：
>>
>> On Sun, Apr 24, 2022 at 09:57:57AM +0800, Surong Pang wrote:
>> > From: Surong Pang <surong.pang@unisoc.com>
>> >
>> > Let usb phy shutdown later in xhci_plat_remove function.
>> > Some phy driver doesn't divide 3.0/2.0 very clear.
>> > If calls usb_phy_shutdown earlier than usb_remove_hcd(hcd),
>> > It will case 10s cmd timeout issue.
>> >
>> > Call usb phy shutdown later has better compatibility.
>> >
>> > Signed-off-by: Surong Pang <surong.pang@unisoc.com>
>>
>> The subject should say "xhci-plat", right?
>>
>> > ---
>> > drivers/usb/host/xhci-plat.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
>> > index 649ffd861b44..fe492ed99cb7 100644
>> > --- a/drivers/usb/host/xhci-plat.c
>> > +++ b/drivers/usb/host/xhci-plat.c
>> > @@ -390,13 +390,13 @@ static int xhci_plat_remove(struct platform_device *dev)
>> >
>> > usb_remove_hcd(shared_hcd);
>> > xhci->shared_hcd = NULL;
>> > - usb_phy_shutdown(hcd->usb_phy);
>> >
>> > usb_remove_hcd(hcd);
>> > usb_put_hcd(shared_hcd);
>> >
>> > clk_disable_unprepare(clk);
>> > clk_disable_unprepare(reg_clk);
>> > + usb_phy_shutdown(hcd->usb_phy);
>> > usb_put_hcd(hcd);
>>
>> Does this fix a specific commit id?
>>
>> thanks,
>>
>> greg k-h