Re: [PATCH v1 0/2] acpi: Remove acpi_release_memory()

Greg Kroah-Hartman
2022-04-26T11:43:32Z

On Mon, Apr 25, 2022 at 02:45:42PM +0300, Heikki Krogerus wrote:
> Hi,
>
> It seems there never were and there never will be actual devices that
> expose the UCSI ACPI mailbox interface. There are now PD controllers
> that support the UCSI interface, but they do not use the ACPI mailbox.
>
> So there is no point in mapping the mailbox with ioremap(), we can
> just use memremap(). That should make it possible to also remove the
> function acpi_release_memory(). That function was only there to make
> it possible to use ioremap() in the UCSI ACPI driver.
>
> thanks,
>
> Heikki Krogerus (2):
> usb: typec: ucsi: acpi: Map the mailbox with memremap()
> acpi: Remove the helper for deactivating memory region
>
> drivers/acpi/osl.c | 86 ------------------------------
> drivers/usb/typec/ucsi/ucsi_acpi.c | 19 ++-----
> include/linux/acpi.h | 3 --
> 3 files changed, 4 insertions(+), 104 deletions(-)
>
> --
> 2.35.1
>

Look good to me, Rafael, want me to take this through the USB tree? Or
if you want to take it through the USB tree, here's my reviewed-by:
either is fine with me.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>