From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jfs: remove unused pointer tblk
Date: Mon, 25 Apr 2022 17:48:05 +0300 [thread overview]
Message-ID: <20220425144804.GP2462@kadam> (raw)
In-Reply-To: <20220424161330.1360068-1-colin.i.king@gmail.com>
On Sun, Apr 24, 2022 at 05:13:30PM +0100, Colin Ian King wrote:
> The pointer tlbk is not used, it is redundant and can be removed.
> Cleans up cppcheck warning:
>
> linux/fs/jfs/jfs_xtree.c:2551:17: style: Unused variable: tblk [unusedVariable]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> fs/jfs/jfs_xtree.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c
> index 3148e9b35f3b..d29979d0a6aa 100644
> --- a/fs/jfs/jfs_xtree.c
> +++ b/fs/jfs/jfs_xtree.c
> @@ -2548,7 +2548,6 @@ xtRelocate(tid_t tid, struct inode * ip, xad_t * oxad, /* old XAD */
> int xtype)
> { /* extent type: XTPAGE or DATAEXT */
> int rc = 0;
> - struct tblock *tblk;
This would have caused a build error if it weren't ifdeffed out.
#ifdef _STILL_TO_PORT
JFS is an IBM filesystem from OS/2. Apparently, this stuff never got
ported? Probably we could just delete the dead code.
regards,
dan carpenter
next prev parent reply other threads:[~2022-04-25 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 16:13 [PATCH] jfs: remove unused pointer tblk Colin Ian King
2022-04-25 14:48 ` Dan Carpenter [this message]
2022-04-25 17:08 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425144804.GP2462@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.i.king@gmail.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox