From: Guenter Roeck <linux@roeck-us.net>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Renze Nicolai <renze@rnplus.nl>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH v2 1/6] dt-bindings: hwmon: Add nuvoton,nct6775
Date: Mon, 25 Apr 2022 08:07:48 -0700 [thread overview]
Message-ID: <20220425150748.GA4165124@roeck-us.net> (raw)
In-Reply-To: <20220309005047.5107-2-zev@bewilderbeest.net>
On Tue, Mar 08, 2022 at 04:50:42PM -0800, Zev Weiss wrote:
> These Super I/O chips have an i2c interface that some systems expose
> to a BMC; the BMC's device tree can now describe that via this
> binding.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
This is still waiting for DT maintainer approval.
Do you expect to add further properties along the line ?
If not, you might consider adding the chips to trivial devices instead.
Guenter
> ---
> .../bindings/hwmon/nuvoton,nct6775.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
> new file mode 100644
> index 000000000000..7b1054db46b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/nuvoton,nct6775.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NCT6775 and compatible Super I/O chips
> +
> +maintainers:
> + - Zev Weiss <zev@bewilderbeest.net>
> +
> +properties:
> + compatible:
> + enum:
> + - nuvoton,nct6106
> + - nuvoton,nct6116
> + - nuvoton,nct6775
> + - nuvoton,nct6776
> + - nuvoton,nct6779
> + - nuvoton,nct6791
> + - nuvoton,nct6792
> + - nuvoton,nct6793
> + - nuvoton,nct6795
> + - nuvoton,nct6796
> + - nuvoton,nct6797
> + - nuvoton,nct6798
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + superio@4d {
> + compatible = "nuvoton,nct6779";
> + reg = <0x4d>;
> + };
> + };
next prev parent reply other threads:[~2022-04-25 15:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 0:50 [PATCH v2 0/6] hwmon: (nct6775) Convert to regmap, add i2c support Zev Weiss
2022-03-09 0:50 ` [PATCH v2 1/6] dt-bindings: hwmon: Add nuvoton,nct6775 Zev Weiss
2022-04-25 15:07 ` Guenter Roeck [this message]
2022-04-26 1:23 ` Zev Weiss
2022-03-09 0:50 ` [PATCH v2 2/6] hwmon: (nct6775) Convert register access to regmap API Zev Weiss
2022-04-25 15:24 ` Guenter Roeck
2022-03-09 0:50 ` [PATCH v2 3/6] hwmon: (nct6775) Rearrange attr-group initialization Zev Weiss
2022-03-09 0:50 ` [PATCH v2 4/6] hwmon: (nct6775) Add read-only mode Zev Weiss
2022-03-09 0:50 ` [PATCH v2 5/6] hwmon: (nct6775) Split core and platform driver Zev Weiss
2022-04-25 15:23 ` Guenter Roeck
2022-03-09 0:50 ` [PATCH v2 6/6] hwmon: (nct6775) Add i2c driver Zev Weiss
2022-04-25 15:37 ` Guenter Roeck
2022-03-09 8:12 ` [PATCH v2 0/6] hwmon: (nct6775) Convert to regmap, add i2c support Paul Menzel
2022-03-09 11:16 ` Zev Weiss
2022-03-10 19:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425150748.GA4165124@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=openbmc@lists.ozlabs.org \
--cc=renze@rnplus.nl \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox