Re: [PATCH V3 6/9] virtio-ccw: implement synchronize_cbs()

Jason Wang
2022-04-26T03:46:28Z

在 2022/4/26 10:50, Halil Pasic 写道:
>>>> +static void virtio_ccw_synchronize_cbs(struct virtio_device *vdev)
>>>> +{
>>>> + struct virtio_ccw_device *vcdev = to_vc_device(vdev);
>>>> + struct airq_info *info = vcdev->airq_info;
>>>> +
>>>> + /*
>>>> + * Synchronize with the vring_interrupt() called by
>>>> + * virtio_ccw_int_handler().
>>>> + */
>>>> + spin_lock(&vcdev->irq_lock);
>>>> + spin_unlock(&vcdev->irq_lock);
>>>> +
>>>> + if (info) {
>>>> + /*
>>>> + * Synchronize with the vring_interrupt() with airq indicator
>>>> + */
>>>> + write_lock(&info->lock);
>>>> + write_unlock(&info->lock);
>>>> + }
>> I think we can make this an either/or operation (devices will either use
>> classic interrupts or adapter interrupts)?
> Right, for virtqueue notifications. I second Connie's motion!

Will do this.

Thanks

>