Re: [PATCH v4 1/5] usb: host: export symbols for xhci-exynos to use xhci hooks

Greg Kroah-Hartman
2022-04-26T10:38:52Z

On Tue, Apr 26, 2022 at 07:27:09PM +0900, Jung Daehwan wrote:
> On Tue, Apr 26, 2022 at 11:54:16AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 26, 2022 at 06:18:44PM +0900, Daehwan Jung wrote:
> > > Export symbols for xhci hooks usage:
> > > xhci_get_slot_ctx
> > > xhci_get_endpoint_address
> > > - Allow xhci hook to get ep_ctx from the xhci_container_ctx for
> > > getting the ep_ctx information to know which ep is offloading and
> > > comparing the context in remote subsystem memory if needed.
> > >
> > > xhci_ring_alloc
> > > - Allow xhci hook to allocate vendor specific ring. Vendors could
> > > alloc additional event ring.
> > >
> > > xhci_trb_virt_to_dma
> > > - Used to retrieve the DMA address of vendor specific ring. Vendors
> > > could get dequeue address of event ring.
> > >
> > > xhci_segment_free
> > > xhci_link_segments
> > > - Allow xhci hook to handle vendor specific segment. Vendors could
> > > directly free or link segments of vendor specific ring.
> > >
> > > xhci_initialize_ring_info
> > > - Allow xhci hook to initialize vendor specific ring.
> > >
> > > xhci_check_trb_in_td_math
> > > - Allow xhci hook to Check TRB math for validation. Vendors could
> > > check trb when allocating vendor specific ring.
> > >
> > > xhci_address_device
> > > - Allow override to give configuration info to Co-processor.
> > >
> > > xhci_bus_suspend
> > > xhci_bus_resume
> > > - Allow override of suspend and resume for power scenario.
> > >
> > > xhci_remove_stream_mapping
> > > - Allow to xhci hook to remove stream mapping. Vendors need to do it
> > > when free-ing vendor specific ring if it's stream type.
> > >
> >
> > For the static functions that you are now exporting, they need to have
> > their functions declared in a .h file. If not, you now get warnings
> > when you run sparse after applying this commit, right?
> >
> > thanks,
> >
> > greg k-h
> >
>
> I didn't get warnings in my environment. I tested to build default config +
> xhci_exynos by make command. Is there compile option to check it?

make "C=1"