From: Guenter Roeck <linux@roeck-us.net>
To: Liu Xinpeng <liuxp11@chinatelecom.cn>
Cc: wim@linux-watchdog.org, tzungbi@kernel.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/3] watchdog: wdat_wdt: Stop watchdog when uninstalling module
Date: Tue, 26 Apr 2022 13:15:41 -0700 [thread overview]
Message-ID: <20220426201541.GM4093517@roeck-us.net> (raw)
In-Reply-To: <1650984810-6247-4-git-send-email-liuxp11@chinatelecom.cn>
On Tue, Apr 26, 2022 at 10:53:30PM +0800, Liu Xinpeng wrote:
> Test shows that wachdog still reboots machine after the module
> is removed. Use watchdog_stop_on_unregister to stop the watchdog
> on removing.
>
> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/wdat_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c
> index 6f36a653767b..e6f95e99156d 100644
> --- a/drivers/watchdog/wdat_wdt.c
> +++ b/drivers/watchdog/wdat_wdt.c
> @@ -463,6 +463,7 @@ static int wdat_wdt_probe(struct platform_device *pdev)
>
> watchdog_set_nowayout(&wdat->wdd, nowayout);
> watchdog_stop_on_reboot(&wdat->wdd);
> + watchdog_stop_on_unregister(&wdat->wdd);
> return devm_watchdog_register_device(dev, &wdat->wdd);
> }
>
> --
> 2.23.0
>
prev parent reply other threads:[~2022-04-26 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 14:53 [PATCH v8 0/3] Some impovements about acpi hardware watchdog Liu Xinpeng
2022-04-26 14:53 ` [PATCH v8 1/3] watchdog: wdat_wdt: Using the existing function to check parameter timeout Liu Xinpeng
2022-04-26 20:15 ` Guenter Roeck
2022-04-26 14:53 ` [PATCH v8 2/3] watchdog: wdat_wdt: Stop watchdog when rebooting the system Liu Xinpeng
2022-04-26 20:15 ` Guenter Roeck
2022-04-26 14:53 ` [PATCH v8 3/3] watchdog: wdat_wdt: Stop watchdog when uninstalling module Liu Xinpeng
2022-04-26 20:15 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426201541.GM4093517@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=liuxp11@chinatelecom.cn \
--cc=tzungbi@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox