From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Phillip Potter <phil@philpotter.co.uk>
Subject: [PATCH 1/3] cdrom: remove the unused driver specific disc change ioctl
Date: Wed, 27 Apr 2022 09:24:33 -0400 [thread overview]
Message-ID: <20220427132436.12795-2-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20220427132436.12795-1-paul.gortmaker@windriver.com>
This was only used by the ide-cd driver, which went away in
commit b7fb14d3ac63 ("ide: remove the legacy ide driver")
so we might as well take advantage of that and get rid of
this hook as well.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
Documentation/cdrom/cdrom-standard.rst | 10 ----------
drivers/cdrom/cdrom.c | 8 --------
include/linux/cdrom.h | 1 -
3 files changed, 19 deletions(-)
diff --git a/Documentation/cdrom/cdrom-standard.rst b/Documentation/cdrom/cdrom-standard.rst
index 52ea7b6b2fe8..7964fe134277 100644
--- a/Documentation/cdrom/cdrom-standard.rst
+++ b/Documentation/cdrom/cdrom-standard.rst
@@ -218,7 +218,6 @@ current *struct* is::
int (*tray_move)(struct cdrom_device_info *, int);
int (*lock_door)(struct cdrom_device_info *, int);
int (*select_speed)(struct cdrom_device_info *, int);
- int (*select_disc)(struct cdrom_device_info *, int);
int (*get_last_session) (struct cdrom_device_info *,
struct cdrom_multisession *);
int (*get_mcn)(struct cdrom_device_info *, struct cdrom_mcn *);
@@ -419,15 +418,6 @@ this `auto-selection` capability, the decision should be made on the
current disc loaded and the return value should be positive. A negative
return value indicates an error.
-::
-
- int select_disc(struct cdrom_device_info *cdi, int number)
-
-If the drive can store multiple discs (a juke-box) this function
-will perform disc selection. It should return the number of the
-selected disc on success, a negative value on error. Currently, only
-the ide-cd driver supports this functionality.
-
::
int get_last_session(struct cdrom_device_info *cdi,
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 2dc9da683a13..0a858bfea849 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -2443,14 +2443,6 @@ static int cdrom_ioctl_select_disc(struct cdrom_device_info *cdi,
return -EINVAL;
}
- /*
- * ->select_disc is a hook to allow a driver-specific way of
- * seleting disc. However, since there is no equivalent hook for
- * cdrom_slot_status this may not actually be useful...
- */
- if (cdi->ops->select_disc)
- return cdi->ops->select_disc(cdi, arg);
-
cd_dbg(CD_CHANGER, "Using generic cdrom_select_disc()\n");
return cdrom_select_disc(cdi, arg);
}
diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h
index 0a89f111e00e..67caa909e3e6 100644
--- a/include/linux/cdrom.h
+++ b/include/linux/cdrom.h
@@ -77,7 +77,6 @@ struct cdrom_device_ops {
int (*tray_move) (struct cdrom_device_info *, int);
int (*lock_door) (struct cdrom_device_info *, int);
int (*select_speed) (struct cdrom_device_info *, int);
- int (*select_disc) (struct cdrom_device_info *, int);
int (*get_last_session) (struct cdrom_device_info *,
struct cdrom_multisession *);
int (*get_mcn) (struct cdrom_device_info *,
--
2.33.0
next prev parent reply other threads:[~2022-04-27 13:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 13:24 [PATCH 0/3] remove remaining IDE driver fragments Paul Gortmaker
2022-04-27 13:24 ` Paul Gortmaker [this message]
2022-04-28 23:28 ` [PATCH 1/3] cdrom: remove the unused driver specific disc change ioctl Phillip Potter
2022-04-27 13:24 ` [PATCH 2/3] cdrom: mark CDROMGETSPINDOWN/CDROMSETSPINDOWN obsolete Paul Gortmaker
2022-04-28 23:32 ` Phillip Potter
2022-04-27 13:24 ` [PATCH 3/3] block: remove last remaining traces of IDE documentation Paul Gortmaker
2022-04-27 14:50 ` Jonathan Corbet
2022-04-27 16:50 ` Randy Dunlap
2022-04-27 16:59 ` Paul Gortmaker
2022-04-28 23:43 ` Phillip Potter
2022-05-06 15:32 ` Paul Gortmaker
2022-05-06 17:54 ` Phillip Potter
2022-05-06 20:24 ` Paul Gortmaker
2022-05-06 20:27 ` Randy Dunlap
2022-05-07 20:57 ` Phillip Potter
2022-05-09 22:17 ` Jonathan Corbet
2022-05-09 23:03 ` Phillip Potter
2022-05-09 23:17 ` Jens Axboe
2022-05-10 8:00 ` Phillip Potter
2022-05-10 5:51 ` Christoph Hellwig
2022-05-10 8:09 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427132436.12795-2-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox