From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Phillip Potter <phil@philpotter.co.uk>
Subject: [PATCH 2/3] cdrom: mark CDROMGETSPINDOWN/CDROMSETSPINDOWN obsolete
Date: Wed, 27 Apr 2022 09:24:34 -0400 [thread overview]
Message-ID: <20220427132436.12795-3-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20220427132436.12795-1-paul.gortmaker@windriver.com>
These were only implemented by the IDE CD driver, which has since
been removed. Given that nobody is likely to create new CD/DVD
hardware (and associated drivers) we can mark these appropriately.
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
Documentation/userspace-api/ioctl/cdrom.rst | 6 ++++++
include/uapi/linux/cdrom.h | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/userspace-api/ioctl/cdrom.rst b/Documentation/userspace-api/ioctl/cdrom.rst
index 682948fc88a3..2ad91dbebd7c 100644
--- a/Documentation/userspace-api/ioctl/cdrom.rst
+++ b/Documentation/userspace-api/ioctl/cdrom.rst
@@ -718,6 +718,9 @@ CDROMPLAYBLK
CDROMGETSPINDOWN
+ Obsolete, was ide-cd only
+
+
usage::
char spindown;
@@ -736,6 +739,9 @@ CDROMGETSPINDOWN
CDROMSETSPINDOWN
+ Obsolete, was ide-cd only
+
+
usage::
char spindown
diff --git a/include/uapi/linux/cdrom.h b/include/uapi/linux/cdrom.h
index 804ff8d98f71..011e594e4a0d 100644
--- a/include/uapi/linux/cdrom.h
+++ b/include/uapi/linux/cdrom.h
@@ -103,7 +103,7 @@
#define CDROMREADALL 0x5318 /* read all 2646 bytes */
/*
- * These ioctls are (now) only in ide-cd.c for controlling
+ * These ioctls were only in (now removed) ide-cd.c for controlling
* drive spindown time. They should be implemented in the
* Uniform driver, via generic packet commands, GPCMD_MODE_SELECT_10,
* GPCMD_MODE_SENSE_10 and the GPMODE_POWER_PAGE...
--
2.33.0
next prev parent reply other threads:[~2022-04-27 13:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 13:24 [PATCH 0/3] remove remaining IDE driver fragments Paul Gortmaker
2022-04-27 13:24 ` [PATCH 1/3] cdrom: remove the unused driver specific disc change ioctl Paul Gortmaker
2022-04-28 23:28 ` Phillip Potter
2022-04-27 13:24 ` Paul Gortmaker [this message]
2022-04-28 23:32 ` [PATCH 2/3] cdrom: mark CDROMGETSPINDOWN/CDROMSETSPINDOWN obsolete Phillip Potter
2022-04-27 13:24 ` [PATCH 3/3] block: remove last remaining traces of IDE documentation Paul Gortmaker
2022-04-27 14:50 ` Jonathan Corbet
2022-04-27 16:50 ` Randy Dunlap
2022-04-27 16:59 ` Paul Gortmaker
2022-04-28 23:43 ` Phillip Potter
2022-05-06 15:32 ` Paul Gortmaker
2022-05-06 17:54 ` Phillip Potter
2022-05-06 20:24 ` Paul Gortmaker
2022-05-06 20:27 ` Randy Dunlap
2022-05-07 20:57 ` Phillip Potter
2022-05-09 22:17 ` Jonathan Corbet
2022-05-09 23:03 ` Phillip Potter
2022-05-09 23:17 ` Jens Axboe
2022-05-10 8:00 ` Phillip Potter
2022-05-10 5:51 ` Christoph Hellwig
2022-05-10 8:09 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427132436.12795-3-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox