* [PATCH] usb: ehci-omap: drop unused ehci_read() function
@ 2022-04-28 10:22 Arnd Bergmann
2022-04-28 18:08 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2022-04-28 10:22 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: Arnd Bergmann, kernel test robot, Roger Quadros, Felipe Balbi,
linux-usb, linux-omap, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
After moving the omap1 platform into generalized multiplatform
support on ARM, the kernel test robot points out a W=1 warning that
now shows up in more configurations:
drivers/usb/host/ehci-omap.c:64:19: warning: unused function 'ehci_read'
The function was last used 9 years ago and can just be removed.
Fixes: 87425ad36330 ("USB: ehci-omap: Remove PHY reset handling code")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/host/ehci-omap.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 7f4a03e8647a..8c45bc17a580 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -61,11 +61,6 @@ static inline void ehci_write(void __iomem *base, u32 reg, u32 val)
__raw_writel(val, base + reg);
}
-static inline u32 ehci_read(void __iomem *base, u32 reg)
-{
- return __raw_readl(base + reg);
-}
-
/* configure so an HC device and id are always provided */
/* always called with process context; sleeping is OK */
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: ehci-omap: drop unused ehci_read() function
2022-04-28 10:22 [PATCH] usb: ehci-omap: drop unused ehci_read() function Arnd Bergmann
@ 2022-04-28 18:08 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2022-04-28 18:08 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, Arnd Bergmann, kernel test robot,
Roger Quadros, Felipe Balbi, linux-usb, linux-omap, linux-kernel
On Thu, Apr 28, 2022 at 12:22:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> After moving the omap1 platform into generalized multiplatform
> support on ARM, the kernel test robot points out a W=1 warning that
> now shows up in more configurations:
>
> drivers/usb/host/ehci-omap.c:64:19: warning: unused function 'ehci_read'
>
> The function was last used 9 years ago and can just be removed.
>
> Fixes: 87425ad36330 ("USB: ehci-omap: Remove PHY reset handling code")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-28 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-28 10:22 [PATCH] usb: ehci-omap: drop unused ehci_read() function Arnd Bergmann
2022-04-28 18:08 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox