Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

Herve Codina
2022-04-28T10:30:34Z

Hi Geert,
On Thu, 28 Apr 2022 11:51:44 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Hervé,
>
> On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <herve.codina@bootlin.com> wrote:
> > Define the r9a06g032 generic part of the USB PHY device node.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm/boot/dts/r9a06g032.dtsi
> > +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> > @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
> > clock-frequency = <0>;
> > };
> >
> > + usbphy: usbphy {
>
> Please preserve sort order (by node name).

Ok, will be done.

>
> > + #phy-cells = <0>;
> > + compatible = "usb-nop-xceiv";
> > + status = "disabled";
> > + };
> > +
> > soc {
> > compatible = "simple-bus";
> > #address-cells = <1>;
>
> The rest LGTM, so with the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>

Regards,
Hervé

--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering