Re: [PATCH 1/4] platform/x86: pmc_atom: remove unused pmc_atom_write()

Hans de Goede
2022-05-06T10:43:40Z

Hi,

On 4/28/22 08:24, Paul Gortmaker wrote:
> This function isn't used anywhere in the driver or anywhere in tree.
> So remove it. It can always be re-added if/when a use arises.
>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Aubrey Li <aubrey.li@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
> Cc: platform-driver-x86@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
> drivers/platform/x86/pmc_atom.c | 12 ------------
> include/linux/platform_data/x86/pmc_atom.h | 1 -
> 2 files changed, 13 deletions(-)
>
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index a40fae6edc84..31cf25d25d66 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -223,18 +223,6 @@ int pmc_atom_read(int offset, u32 *value)
> }
> EXPORT_SYMBOL_GPL(pmc_atom_read);
>
> -int pmc_atom_write(int offset, u32 value)
> -{
> - struct pmc_dev *pmc = &pmc_device;
> -
> - if (!pmc->init)
> - return -ENODEV;
> -
> - pmc_reg_write(pmc, offset, value);
> - return 0;
> -}
> -EXPORT_SYMBOL_GPL(pmc_atom_write);
> -
> static void pmc_power_off(void)
> {
> u16 pm1_cnt_port;
> diff --git a/include/linux/platform_data/x86/pmc_atom.h b/include/linux/platform_data/x86/pmc_atom.h
> index 022bcea9edec..6807839c718b 100644
> --- a/include/linux/platform_data/x86/pmc_atom.h
> +++ b/include/linux/platform_data/x86/pmc_atom.h
> @@ -144,6 +144,5 @@
> #define SLEEP_ENABLE 0x2000
>
> extern int pmc_atom_read(int offset, u32 *value);
> -extern int pmc_atom_write(int offset, u32 value);
>
> #endif /* PMC_ATOM_H */