public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: dac: ltc2632: Make use of device properties
Date: Thu, 28 Apr 2022 19:34:47 +0100	[thread overview]
Message-ID: <20220428193447.33b2d4a7@jic23-huawei> (raw)
In-Reply-To: <20220413192203.46704-1-andriy.shevchenko@linux.intel.com>

On Wed, 13 Apr 2022 22:22:03 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Hi Andy,

Not sure why I was sitting on this one.

Anyhow, now applied to the togreg branch of iio.git and pushed out
as testing for all the normal reasons.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ltc2632.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c
> index aed46c80757e..c0255f402056 100644
> --- a/drivers/iio/dac/ltc2632.c
> +++ b/drivers/iio/dac/ltc2632.c
> @@ -10,6 +10,7 @@
>  #include <linux/spi/spi.h>
>  #include <linux/module.h>
>  #include <linux/iio/iio.h>
> +#include <linux/property.h>
>  #include <linux/regulator/consumer.h>
>  
>  #include <asm/unaligned.h>
> @@ -362,8 +363,7 @@ static int ltc2632_probe(struct spi_device *spi)
>  		}
>  	}
>  
> -	indio_dev->name = dev_of_node(&spi->dev) ? dev_of_node(&spi->dev)->name
> -						 : spi_get_device_id(spi)->name;
> +	indio_dev->name = fwnode_get_name(dev_fwnode(&spi->dev)) ?: spi_get_device_id(spi)->name;
>  	indio_dev->info = &ltc2632_info;
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  	indio_dev->channels = chip_info->channels;
> @@ -469,7 +469,7 @@ MODULE_DEVICE_TABLE(of, ltc2632_of_match);
>  static struct spi_driver ltc2632_driver = {
>  	.driver		= {
>  		.name	= "ltc2632",
> -		.of_match_table = of_match_ptr(ltc2632_of_match),
> +		.of_match_table = ltc2632_of_match,
>  	},
>  	.probe		= ltc2632_probe,
>  	.remove		= ltc2632_remove,


      reply	other threads:[~2022-04-28 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 19:22 [PATCH v1 1/1] iio: dac: ltc2632: Make use of device properties Andy Shevchenko
2022-04-28 18:34 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428193447.33b2d4a7@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox