Re: [PATCH] ELF, uapi: fixup ELF_ST_TYPE definition

Kees Cook
2022-04-29T17:25:30Z

On Fri, Apr 29, 2022 at 05:50:03PM +0300, Alexey Dobriyan wrote:
> This is very theoretical compile failure:
>
> ELF_ST_TYPE(st_info = A)
>
> Cast will bind first and st_info will stop being lvalue:
>
> error: lvalue required as left operand of assignment
>
> Given that the only use of this macro is
>
> ELF_ST_TYPE(sym->st_info)
>
> where st_info is "unsigned char" I've decided to remove cast especially
> given that companion macro ELF_ST_BIND doesn't use cast.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> include/uapi/linux/elf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

It looks like akpm already pulled this, so:

Acked-by: Kees Cook <keescook@chromium.org>

Please keep Eric & I CCed on ELF changes; there's a MAINTAINERS entry
now...

-Kees

--
Kees Cook