Re: [PATCH 4.19 00/53] 4.19.240-rc1 review [net: ethernet: stmmac: fix altr_tse_pcs function when using a]

Dinh Nguyen
2022-04-29T15:53:43Z

On 4/29/22 04:22, Greg Kroah-Hartman wrote:
> On Fri, Apr 29, 2022 at 09:43:41AM +0200, Pavel Machek wrote:
>> Hi!
>>
>>>>> This is the start of the stable review cycle for the 4.19.240 release.
>>>>> There are 53 patches in this series, all will be posted as a response
>>>>> to this one. If anyone has any issues with these being applied, please
>>>>> let me know.
>> ...
>>>> I still see problems on socfpga:
>>>>
>>>> [ 1.227759] mmcblk0: p1 p2 p3
>>>> [ 1.269825] Micrel KSZ9031 Gigabit PHY stmmac-0:01: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:01, irq=POLL)
>>>> [ 1.284600] socfpga-dwmac ff702000.ethernet eth0: No Safety Features support found
>>>> [ 1.292374] socfpga-dwmac ff702000.ethernet eth0: registered PTP clock
>>>> [ 1.299247] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>> [ 5.444552] Unable to handle kernel NULL pointer dereference at virtual address 00000000
>> ...
>>>> [ 5.478679] Workqueue: events_power_efficient phy_state_machine
>>>> [ 5.484579] PC is at socfpga_dwmac_fix_mac_speed+0x3c/0xbc
>>>> [ 5.490044] LR is at arm_heavy_mb+0x2c/0x48
>>
>>>> https://lava.ciplatform.org/scheduler/job/669257
>>>> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/2377419824
>>>
>>> Can you run git bisect?
>>
>> Not a bisect, but we guessed e2423aa174e6 was responsible, and tested
>> it boots with that patch reverted.
>>
>> Best regards,
>> Pavel
>>
>> commit e2423aa174e6c3e9805e96db778245ba73cdd88c
>>
>> net: ethernet: stmmac: fix altr_tse_pcs function when using a
>> fixed-link
>>
>> [ Upstream commit a6aaa00324240967272b451bfa772547bd576ee6 ]
>>
>
> Thanks, now reverted from 4.19.y, 4.14.y, and 4.9.y
>

I have fixed this with this patch that is in linux-next:

5fd1fe4807f9 ("net: ethernet: stmmac: fix write to sgmii_adapter_base")

Dinh