From: Colin Foster <colin.foster@in-advantage.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
UNGLinuxDriver@microchip.com,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH v1 net 1/2] net: ethernet: ocelot: rename vcap_props to clearly be an ocelot member
Date: Sat, 30 Apr 2022 10:36:15 -0700 [thread overview]
Message-ID: <20220430173615.GC3846867@euler> (raw)
In-Reply-To: <20220429190752.36a8f4dd@kernel.org>
Hi Jakub,
On Fri, Apr 29, 2022 at 07:07:52PM -0700, Jakub Kicinski wrote:
> On Fri, 29 Apr 2022 16:30:48 -0700 Colin Foster wrote:
> > The vcap_props structure is part of the ocelot driver. It is in the process
> > of being exported to a wider scope, so renaming it to match other structure
> > definitions in the include/soc/mscc/ocelot.h makes sense.
> >
> > I'm splitting the rename operation into this separate commit, since it
> > should make the actual bug fix (next commit) easier to review.
>
> Sure, but is it really necessary to do it now, or can we do it later
> in net-next? There's only one struct vcap_props in the tree AFAICT.
I see your point. There wouldn't be a name collision, so the change
isn't absolutely necessary - just a nice convention. So I could have
patched the "bug" in net, then done the rename in net-next. I hadn't
considered this.
It seems like this patch set is bound for net-next in some way, shape,
or form, so it might be a non-issue.
Thanks for the feedback!
next prev parent reply other threads:[~2022-04-30 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 23:30 [PATCH v1 net 0/2] fix shared vcap_props reference Colin Foster
2022-04-29 23:30 ` [PATCH v1 net 1/2] net: ethernet: ocelot: rename vcap_props to clearly be an ocelot member Colin Foster
2022-04-30 2:07 ` Jakub Kicinski
2022-04-30 17:36 ` Colin Foster [this message]
2022-04-29 23:30 ` [PATCH v1 net 2/2] net: mscc: ocelot: fix possible memory conflict for vcap_props Colin Foster
2022-04-30 2:06 ` Jakub Kicinski
2022-04-30 17:27 ` Colin Foster
2022-04-30 14:24 ` Vladimir Oltean
2022-04-30 17:24 ` Colin Foster
2022-04-30 21:56 ` Vladimir Oltean
2022-04-30 22:26 ` Colin Foster
2022-05-01 10:52 ` [PATCH v1 net 0/2] fix shared vcap_props reference Vladimir Oltean
2022-05-01 21:09 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220430173615.GC3846867@euler \
--to=colin.foster@in-advantage.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox