Re: [PATCH v2 01/26] modpost: use bool type where appropriate

Masahiro Yamada
2022-05-04T05:49:05Z

On Wed, May 4, 2022 at 6:43 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> On Sun, May 1, 2022 at 1:42 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h
> > index 96d6b3a16ca2..7ccfcc8899c1 100644
> > --- a/scripts/mod/modpost.h
> > +++ b/scripts/mod/modpost.h
> > @@ -1,4 +1,5 @@
> > /* SPDX-License-Identifier: GPL-2.0 */
> > +#include <stdbool.h>
> > #include <stdio.h>
> > #include <stdlib.h>
> > #include <stdarg.h>
> > @@ -111,11 +112,10 @@ struct module {
> > struct module *next;
> > int gpl_compatible;
> > struct symbol *unres;
> > - int from_dump; /* 1 if module was loaded from *.symvers */
> > - int is_vmlinux;
> > - int seen;
> > - int has_init;
> > - int has_cleanup;
> > + bool from_dump; /* true if module was loaded from *.symvers */
> > + bool is_vmlinux;
> > + bool seen;
> > + bool has_init, has_cleanup;
>
> Consider keeping these on separate lines. Either way:

OK, I will keep them on separate lines.

> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> --
> Thanks,
> ~Nick Desaulniers

--
Best Regards
Masahiro Yamada