* [tip:master 18/29] fs/ntfs3/ntfs3.prelink.o: warning: objtool: ni_read_frame() falls through to next function ni_readpage_cmpr.cold()
@ 2022-05-02 2:34 kernel test robot
2022-05-02 9:15 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2022-05-02 2:34 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: kbuild-all, linux-kernel, x86, Borislav Petkov
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master
head: aea1ae1ab93e60b266453b008238fbc5f0c65865
commit: ad0952ac67d1bd2c1e0c25ce150b981f02cc23a3 [18/29] Merge objtool/core into tip/master
config: x86_64-randconfig-c001-20220502 (https://download.01.org/0day-ci/archive/20220502/202205021021.6sless1W-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=ad0952ac67d1bd2c1e0c25ce150b981f02cc23a3
git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
git fetch --no-tags tip master
git checkout ad0952ac67d1bd2c1e0c25ce150b981f02cc23a3
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/ntfs3/ntfs3.prelink.o: warning: objtool: ni_read_frame() falls through to next function ni_readpage_cmpr.cold()
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [tip:master 18/29] fs/ntfs3/ntfs3.prelink.o: warning: objtool: ni_read_frame() falls through to next function ni_readpage_cmpr.cold() 2022-05-02 2:34 [tip:master 18/29] fs/ntfs3/ntfs3.prelink.o: warning: objtool: ni_read_frame() falls through to next function ni_readpage_cmpr.cold() kernel test robot @ 2022-05-02 9:15 ` Peter Zijlstra 2022-05-30 10:38 ` [tip: objtool/urgent] objtool: Mark __ubsan_handle_builtin_unreachable() as noreturn tip-bot2 for Peter Zijlstra 0 siblings, 1 reply; 3+ messages in thread From: Peter Zijlstra @ 2022-05-02 9:15 UTC (permalink / raw) To: kernel test robot Cc: kbuild-all, linux-kernel, x86, Borislav Petkov, Josh Poimboeuf On Mon, May 02, 2022 at 10:34:28AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master > head: aea1ae1ab93e60b266453b008238fbc5f0c65865 > commit: ad0952ac67d1bd2c1e0c25ce150b981f02cc23a3 [18/29] Merge objtool/core into tip/master > config: x86_64-randconfig-c001-20220502 (https://download.01.org/0day-ci/archive/20220502/202205021021.6sless1W-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=ad0952ac67d1bd2c1e0c25ce150b981f02cc23a3 > git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > git fetch --no-tags tip master > git checkout ad0952ac67d1bd2c1e0c25ce150b981f02cc23a3 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > >> fs/ntfs3/ntfs3.prelink.o: warning: objtool: ni_read_frame() falls through to next function ni_readpage_cmpr.cold() That is in fact: 000000000000124a <ni_read_frame.cold>: 124a: 44 89 e0 mov %r12d,%eax 124d: 0f b6 55 98 movzbl -0x68(%rbp),%edx 1251: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 1254: R_X86_64_32S .data+0x1380 1258: 48 89 c6 mov %rax,%rsi 125b: e8 00 00 00 00 call 1260 <ni_read_frame.cold+0x16> 125c: R_X86_64_PLT32 __ubsan_handle_shift_out_of_bounds-0x4 1260: 48 8d 7d cc lea -0x34(%rbp),%rdi 1264: e8 00 00 00 00 call 1269 <ni_read_frame.cold+0x1f> 1265: R_X86_64_PLT32 __tsan_read4-0x4 1269: 8b 45 cc mov -0x34(%rbp),%eax 126c: e9 00 00 00 00 jmp 1271 <ni_read_frame.cold+0x27> 126d: R_X86_64_PC32 .text+0x19109 1271: 48 8b 75 a0 mov -0x60(%rbp),%rsi 1275: 48 63 d0 movslq %eax,%rdx 1278: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 127b: R_X86_64_32S .data+0x13a0 127f: 89 45 88 mov %eax,-0x78(%rbp) 1282: e8 00 00 00 00 call 1287 <ni_read_frame.cold+0x3d> 1283: R_X86_64_PLT32 __ubsan_handle_shift_out_of_bounds-0x4 1287: 8b 45 88 mov -0x78(%rbp),%eax 128a: e9 00 00 00 00 jmp 128f <ni_read_frame.cold+0x45> 128b: R_X86_64_PC32 .text+0x19098 128f: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 1292: R_X86_64_32S .data+0x11f0 1296: e8 00 00 00 00 call 129b <ni_readpage_cmpr.cold> 1297: R_X86_64_PLT32 __ubsan_handle_builtin_unreachable-0x4 000000000000129b <ni_readpage_cmpr.cold>: The below seems to fix. --- diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 2063f9fea1a2..d5189f5ec69e 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -185,6 +185,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, "stop_this_cpu", "__invalid_creds", "cpu_startup_entry", + "__ubsan_handle_builtin_unreachable", }; if (!func) ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip: objtool/urgent] objtool: Mark __ubsan_handle_builtin_unreachable() as noreturn 2022-05-02 9:15 ` Peter Zijlstra @ 2022-05-30 10:38 ` tip-bot2 for Peter Zijlstra 0 siblings, 0 replies; 3+ messages in thread From: tip-bot2 for Peter Zijlstra @ 2022-05-30 10:38 UTC (permalink / raw) To: linux-tip-commits Cc: kernel test robot, Peter Zijlstra (Intel), x86, linux-kernel The following commit has been merged into the objtool/urgent branch of tip: Commit-ID: 385bd430c011a8cb8278e61c32d602d11e06f414 Gitweb: https://git.kernel.org/tip/385bd430c011a8cb8278e61c32d602d11e06f414 Author: Peter Zijlstra <peterz@infradead.org> AuthorDate: Mon, 02 May 2022 11:15:14 +02:00 Committer: Peter Zijlstra <peterz@infradead.org> CommitterDate: Fri, 27 May 2022 12:34:43 +02:00 objtool: Mark __ubsan_handle_builtin_unreachable() as noreturn fs/ntfs3/ntfs3.prelink.o: warning: objtool: ni_read_frame() falls through to next function ni_readpage_cmpr.cold() That is in fact: 000000000000124a <ni_read_frame.cold>: 124a: 44 89 e0 mov %r12d,%eax 124d: 0f b6 55 98 movzbl -0x68(%rbp),%edx 1251: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 1254: R_X86_64_32S .data+0x1380 1258: 48 89 c6 mov %rax,%rsi 125b: e8 00 00 00 00 call 1260 <ni_read_frame.cold+0x16> 125c: R_X86_64_PLT32 __ubsan_handle_shift_out_of_bounds-0x4 1260: 48 8d 7d cc lea -0x34(%rbp),%rdi 1264: e8 00 00 00 00 call 1269 <ni_read_frame.cold+0x1f> 1265: R_X86_64_PLT32 __tsan_read4-0x4 1269: 8b 45 cc mov -0x34(%rbp),%eax 126c: e9 00 00 00 00 jmp 1271 <ni_read_frame.cold+0x27> 126d: R_X86_64_PC32 .text+0x19109 1271: 48 8b 75 a0 mov -0x60(%rbp),%rsi 1275: 48 63 d0 movslq %eax,%rdx 1278: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 127b: R_X86_64_32S .data+0x13a0 127f: 89 45 88 mov %eax,-0x78(%rbp) 1282: e8 00 00 00 00 call 1287 <ni_read_frame.cold+0x3d> 1283: R_X86_64_PLT32 __ubsan_handle_shift_out_of_bounds-0x4 1287: 8b 45 88 mov -0x78(%rbp),%eax 128a: e9 00 00 00 00 jmp 128f <ni_read_frame.cold+0x45> 128b: R_X86_64_PC32 .text+0x19098 128f: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 1292: R_X86_64_32S .data+0x11f0 1296: e8 00 00 00 00 call 129b <ni_readpage_cmpr.cold> 1297: R_X86_64_PLT32 __ubsan_handle_builtin_unreachable-0x4 000000000000129b <ni_readpage_cmpr.cold>: Tell objtool that __ubsan_handle_builtin_unreachable() is a noreturn. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20220502091514.GB479834@worktop.programming.kicks-ass.net --- tools/objtool/check.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 190b2f6..7a187da 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -185,7 +185,8 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, "do_group_exit", "stop_this_cpu", "__invalid_creds", - "cpu_startup_entry", + "cpu_startup_entry", + "__ubsan_handle_builtin_unreachable", }; if (!func) ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-30 10:39 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-05-02 2:34 [tip:master 18/29] fs/ntfs3/ntfs3.prelink.o: warning: objtool: ni_read_frame() falls through to next function ni_readpage_cmpr.cold() kernel test robot 2022-05-02 9:15 ` Peter Zijlstra 2022-05-30 10:38 ` [tip: objtool/urgent] objtool: Mark __ubsan_handle_builtin_unreachable() as noreturn tip-bot2 for Peter Zijlstra
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox