Re: [PATCH] fsnotify: add generic perm check for unlink/rmdir

kernel test robot
2022-05-04T07:02:09Z

Hi Guowei,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pcmoore-selinux/next]
[also build test WARNING on linus/master jmorris-security/next-testing v5.18-rc5]
[cannot apply to jack-fs/fsnotify next-20220503]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Guowei-Du/fsnotify-add-generic-perm-check-for-unlink-rmdir/20220504-024310
base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next
config: h8300-randconfig-s032-20220501 (https://download.01.org/0day-ci/archive/20220504/202205041421.bHwZBEFK-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/intel-lab-lkp/linux/commit/6f635019bbd2ab22a64e03164c8812a46531966e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Guowei-Du/fsnotify-add-generic-perm-check-for-unlink-rmdir/20220504-024310
git checkout 6f635019bbd2ab22a64e03164c8812a46531966e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=h8300 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
security/security.c:358:25: sparse: sparse: cast removes address space '__rcu' of expression
>> security/security.c:1169:35: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct path *path @@ got struct path const *dir @@
security/security.c:1169:35: sparse: expected struct path *path
security/security.c:1169:35: sparse: got struct path const *dir
security/security.c:1180:35: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct path *path @@ got struct path const *dir @@
security/security.c:1180:35: sparse: expected struct path *path
security/security.c:1180:35: sparse: got struct path const *dir

vim +1169 security/security.c

1160
1161 int security_path_rmdir(const struct path *dir, struct dentry *dentry)
1162 {
1163 int ret;
1164 if (unlikely(IS_PRIVATE(d_backing_inode(dir->dentry))))
1165 return 0;
1166 ret = call_int_hook(path_rmdir, 0, dir, dentry);
1167 if (ret)
1168 return ret;
> 1169 return fsnotify_path_perm(dir, dentry, MAY_RMDIR);
1170 }
1171

--
0-DAY CI Kernel Test Service