Re: [PATCH] fsnotify: add generic perm check for unlink/rmdir

kernel test robot
2022-05-04T01:21:47Z

Hi Guowei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pcmoore-selinux/next]
[also build test ERROR on linus/master v5.18-rc5]
[cannot apply to jack-fs/fsnotify next-20220503]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Guowei-Du/fsnotify-add-generic-perm-check-for-unlink-rmdir/20220504-024310
base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next
config: hexagon-randconfig-r041-20220501 (https://download.01.org/0day-ci/archive/20220504/202205040959.SAV6vlzH-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 363b3a645a1e30011cc8da624f13dac5fd915628)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6f635019bbd2ab22a64e03164c8812a46531966e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Guowei-Du/fsnotify-add-generic-perm-check-for-unlink-rmdir/20220504-024310
git checkout 6f635019bbd2ab22a64e03164c8812a46531966e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> security/security.c:1169:28: error: passing 'const struct path *' to parameter of type 'struct path *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
return fsnotify_path_perm(dir, dentry, MAY_RMDIR);
^~~
include/linux/fsnotify.h:83:51: note: passing argument to parameter 'path' here
static inline int fsnotify_path_perm(struct path *path, struct dentry *dentry, __u32 mask)
^
security/security.c:1180:28: error: passing 'const struct path *' to parameter of type 'struct path *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
return fsnotify_path_perm(dir, dentry, MAY_UNLINK);
^~~
include/linux/fsnotify.h:83:51: note: passing argument to parameter 'path' here
static inline int fsnotify_path_perm(struct path *path, struct dentry *dentry, __u32 mask)
^
2 errors generated.

vim +1169 security/security.c

1160
1161 int security_path_rmdir(const struct path *dir, struct dentry *dentry)
1162 {
1163 int ret;
1164 if (unlikely(IS_PRIVATE(d_backing_inode(dir->dentry))))
1165 return 0;
1166 ret = call_int_hook(path_rmdir, 0, dir, dentry);
1167 if (ret)
1168 return ret;
> 1169 return fsnotify_path_perm(dir, dentry, MAY_RMDIR);
1170 }
1171

--
0-DAY CI Kernel Test Service