From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF9DC433F5 for ; Wed, 4 May 2022 18:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376523AbiEDSHv convert rfc822-to-8bit (ORCPT ); Wed, 4 May 2022 14:07:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376484AbiEDSHh (ORCPT ); Wed, 4 May 2022 14:07:37 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 375AF6EC61 for ; Wed, 4 May 2022 10:23:00 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 0F6411C0BA5; Wed, 4 May 2022 19:22:57 +0200 (CEST) Date: Wed, 4 May 2022 19:22:56 +0200 From: Pavel Machek To: Charles Mirabile Cc: linux-kernel@vger.kernel.org, Serge Schneider , Stefan Wahren , Nicolas Saenz Julienne , Mattias Brugger , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, fedora-rpi@googlegroups.com, Miguel Ojeda , Daniel Bauman , Mwesigwa Guma , Joel Savitz Subject: Re: [PATCH v9 3/6] drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver Message-ID: <20220504172256.GA1623@bug> References: <20220419205158.28088-1-cmirabil@redhat.com> <20220419205158.28088-4-cmirabil@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20220419205158.28088-4-cmirabil@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > This patch adds the driver for the 8x8 RGB LED matrix display > on the Sense HAT. It appears as a character device named sense-hat > in /dev/. That special file is 192 bytes large and contains 64 > RGB triplets (3 bytes each) one for each pixel in row major order. Is that right interface? Should we treat it as a tiny framebuffer, instead? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html