[andersson:wip/sc8180x-next-20220502 6/29] drivers/gpu/drm/msm/dp/dp_hpd.c:63:53: warning: converting the enum constant to a boolean

kernel test robot
2022-05-04T11:07:55Z

tree: https://github.com/andersson/kernel wip/sc8180x-next-20220502
head: 6199153320a3b7d1dce23ad1ea4d894a86793cb6
commit: be6e31f126bed33f684250905b79d76f7664d985 [6/29] drm/msm/dp: Add typec_mux implementation
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220504/202205041920.TXQhAxL4-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 363b3a645a1e30011cc8da624f13dac5fd915628)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/andersson/kernel/commit/be6e31f126bed33f684250905b79d76f7664d985
git remote add andersson https://github.com/andersson/kernel
git fetch --no-tags andersson wip/sc8180x-next-20220502
git checkout be6e31f126bed33f684250905b79d76f7664d985
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/msm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/msm/dp/dp_hpd.c:63:53: warning: converting the enum constant to a boolean [-Wint-in-bool-context]
usbpd->multi_func = pin_assign == DP_PIN_ASSIGN_C || DP_PIN_ASSIGN_E;
^
1 warning generated.

vim +63 drivers/gpu/drm/msm/dp/dp_hpd.c

52
53 static int dp_hpd_mux_set(struct typec_mux_dev *mux, struct typec_mux_state *state)
54 {
55 struct dp_hpd_private *dp_hpd = typec_mux_get_drvdata(mux);
56 struct dp_usbpd *usbpd = &dp_hpd->dp_usbpd;
57 struct typec_displayport_data *dp_data = state->data;
58 int pin_assign = 0;
59
60 if (dp_data) {
61 pin_assign = DP_CONF_GET_PIN_ASSIGN(dp_data->conf);
62 usbpd->hpd_irq = !!(dp_data->status & DP_STATUS_IRQ_HPD);
> 63 usbpd->multi_func = pin_assign == DP_PIN_ASSIGN_C || DP_PIN_ASSIGN_E;
64 }
65
66 if (!pin_assign) {
67 if (dp_hpd->connected) {
68 dp_hpd->connected = false;
69 dp_hpd->dp_cb->disconnect(dp_hpd->dev);
70 }
71 } else if (!dp_hpd->connected) {
72 dp_hpd->connected = true;
73 dp_hpd->dp_cb->configure(dp_hpd->dev);
74 } else {
75 dp_hpd->dp_cb->attention(dp_hpd->dev);
76 }
77
78 return 0;
79 }
80

--
0-DAY CI Kernel Test Service