Re: [PATCH v3 15/21] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring()

Jarkko Sakkinen
2022-05-18T14:56:17Z

On Wed, May 18, 2022 at 11:41:51AM +0200, Juergen Gross wrote:
> On 07.05.22 00:32, Jarkko Sakkinen wrote:
> > On Thu, May 05, 2022 at 10:16:34AM +0200, Juergen Gross wrote:
> > > Simplify tpmfront's ring creation and removal via xenbus_setup_ring()
> > > and xenbus_teardown_ring().
> > >
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> >
> > Please add to the commit message why these provide an equivalent
> > functionality.
>
> Would you be fine with:
>
> Simplify tpmfront's ring creation and removal via xenbus_setup_ring()
> and xenbus_teardown_ring(), which are provided exactly for the use
> pattern as seen in this driver.
>
>
> Juergen

Looks fine to me!

BR, Jarkko