* [PATCH] ssb: remove unreachable code
@ 2022-05-06 7:58 Jiapeng Chong
2022-05-06 15:29 ` Michael Büsch
2022-05-11 5:29 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2022-05-06 7:58 UTC (permalink / raw)
To: m; +Cc: linux-wireless, linux-kernel, Jiapeng Chong, Abaci Robot
Clean up the following smatch warning:
drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
code.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/ssb/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 148bcb99c212..493bebbba521 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
err = 0;
goto out_free;
}
- pr_warn("WARNING: Invalid SPROM CRC (corrupt SPROM)\n");
}
}
err = sprom_extract(bus, sprom, buf, bus->sprom_size);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ssb: remove unreachable code
2022-05-06 7:58 [PATCH] ssb: remove unreachable code Jiapeng Chong
@ 2022-05-06 15:29 ` Michael Büsch
2022-05-11 5:29 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Michael Büsch @ 2022-05-06 15:29 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-wireless, linux-kernel, Abaci Robot
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Fri, 6 May 2022 15:58:14 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Clean up the following smatch warning:
>
> drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
> code.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/ssb/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index 148bcb99c212..493bebbba521 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -914,7 +914,6 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
> err = 0;
> goto out_free;
> }
> - pr_warn("WARNING: Invalid SPROM CRC (corrupt
> SPROM)\n"); }
> }
> err = sprom_extract(bus, sprom, buf, bus->sprom_size);
Acked-by: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ssb: remove unreachable code
2022-05-06 7:58 [PATCH] ssb: remove unreachable code Jiapeng Chong
2022-05-06 15:29 ` Michael Büsch
@ 2022-05-11 5:29 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-05-11 5:29 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: m, linux-wireless, linux-kernel, Jiapeng Chong, Abaci Robot
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Clean up the following smatch warning:
>
> drivers/ssb/pci.c:917 ssb_pci_sprom_get() warn: ignoring unreachable
> code.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Acked-by: Michael Büsch <m@bues.ch>
Patch applied to wireless-next.git, thanks.
84dc992e23df ssb: remove unreachable code
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220506075814.115059-1-jiapeng.chong@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-11 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-06 7:58 [PATCH] ssb: remove unreachable code Jiapeng Chong
2022-05-06 15:29 ` Michael Büsch
2022-05-11 5:29 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox