Re: [PATCH 1/4] perf report: Do not extend sample type of bpf-output event

Namhyung Kim
2022-05-12T06:00:26Z

Hi Arnaldo,

On Tue, May 10, 2022 at 9:50 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Fri, May 06, 2022 at 01:16:24PM -0700, Namhyung Kim escreveu:
> > Currently evsel__new_idx() sets more sample_type bits when it finds a
> > BPF-output event. But it should honor what's recorded in the perf
> > data file rather than blindly sets the bits. Otherwise it could lead
> > to a parse error when it recorded with a modified sample_type.
>
> Can you please try to provide a Fixes: tag for this? This way reviewing
> gets simpler by looking at who introduced this, if there was some reason
> or if it was a plain oversight.
>
> It also helps to get this fix propabated to the stable trees.

Well.. actually this is not a fix. I've realized it adds some
sample types when it creates a new evsel regardless of
the perf_event_attr.

This was not a problem so far (as nobody touched it),
but when I changed some sample types during record
for this change, perf report sees a different value and
rejects the data.

Thanks,
namhyung