Re: [PATCH v2 07/11] dt-bindings: clocks: qcom,gcc-ipq8074: support power domains

Krzysztof Kozlowski
2022-05-09T07:25:37Z

On 07/05/2022 22:29, Robert Marko wrote:
> GCC inside of IPQ8074 also provides power management via built-in GDSCs.
> In order to do so, '#power-domain-cells' must be set to 1.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> .../devicetree/bindings/clock/qcom,gcc-ipq8074.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml
> index 98572b4a9b60..e3e236e4ce7d 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml
> @@ -27,6 +27,9 @@ properties:
> '#reset-cells':
> const: 1
>
> + '#power-domain-cells':

Put it in some order, e.g. before reset-cells.

> + const: 1
> +
> reg:
> maxItems: 1
>
> @@ -39,6 +42,7 @@ required:
> - reg
> - '#clock-cells'
> - '#reset-cells'
> + - '#power-domain-cells'

The same.

>
> additionalProperties: false
>
> @@ -49,5 +53,6 @@ examples:
> reg = <0x01800000 0x80000>;
> #clock-cells = <1>;
> #reset-cells = <1>;
> + #power-domain-cells = <1>;

The same.

> };
> ...

Best regards,
Krzysztof