From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35876C433F5 for ; Tue, 10 May 2022 05:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236702AbiEJF0k (ORCPT ); Tue, 10 May 2022 01:26:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232892AbiEJF0i (ORCPT ); Tue, 10 May 2022 01:26:38 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A8BBE24313A for ; Mon, 9 May 2022 22:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652160160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dSBUCgbnrXyS4xiqIulcu9NB35K8gsqks7zGiCMctnI=; b=eMvvOnxZVju0Qn/r4vabodhWw/ZaQUWPlheooLgW4Uq1uxgnqxIOgToaP+fJm2ivnrSVaw bKpcOF7G3sr9Q7yZXi/KiFROxmY5k3Xlopim1Pot1sZ7wC0vJvexaa1vro+iggkJ8qzTDi EF6obd0htx4l9Ck1LEbEGT84OgYHLpE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-153-IYrWemIDNhe_Nvw0FaHRNw-1; Tue, 10 May 2022 01:22:39 -0400 X-MC-Unique: IYrWemIDNhe_Nvw0FaHRNw-1 Received: by mail-wr1-f71.google.com with SMTP id l7-20020adfa387000000b0020acc61dbaeso6622495wrb.7 for ; Mon, 09 May 2022 22:22:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dSBUCgbnrXyS4xiqIulcu9NB35K8gsqks7zGiCMctnI=; b=6CMSH9B1RvH31Ek0WIBIH8XzdOwNXtr6IZRycJEtsOK+Eu7/7zYPLeKZ5m+wp21ei2 Z/hO4Lf89cGhr92ObGrFnRjulwUkzvmauCiPZleTUUNLNm8sVcN6jb4qziiMzhYWw+Mt QecpEVeokxEdVxtK20qnZRZvHpojfKkAlHagimFvrCeBgWoj8bDdb04RV1IVlQu4O40J 2Ckp3hhgErxTMD2am8mwGDx16UuK7Ximkz5O+dDc88L/sDIALLS26hXz5LQSFsjUPmA3 7pBLqxwJtJbr/BhYdRNmD/wbC3fqH+X4UbEKnnE+xMak1kxfDfqeVKslmcuZEUI/OZ7X aAyg== X-Gm-Message-State: AOAM530kkSVBRkGCIpPSGObvAPSy0xUW7RmjOVBL+YQPo0yxFcYwPaU9 lhRkd+sfDb5VcLZ+Njyh9DEMlkoWVP2aTrscj9x41XT+w11hmyaRc5B0ohzti4cv+7DzsY4PTuH CbB9yzfNd9NB2Rw3xQylX5ZBo X-Received: by 2002:a05:600c:378b:b0:394:3894:3a65 with SMTP id o11-20020a05600c378b00b0039438943a65mr19610050wmr.18.1652160158269; Mon, 09 May 2022 22:22:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhdbrn6t2cTRanVgLinK3hRXX7cC5Jz0nyau26pq9cmJz/uWA/9EYU3xUh3J1fN8kX9UjBNA== X-Received: by 2002:a05:600c:378b:b0:394:3894:3a65 with SMTP id o11-20020a05600c378b00b0039438943a65mr19610035wmr.18.1652160158047; Mon, 09 May 2022 22:22:38 -0700 (PDT) Received: from redhat.com ([2.55.130.230]) by smtp.gmail.com with ESMTPSA id a15-20020a056000100f00b0020c5253d8d9sm12974968wrx.37.2022.05.09.22.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 22:22:37 -0700 (PDT) Date: Tue, 10 May 2022 01:22:34 -0400 From: "Michael S. Tsirkin" To: Tang Bin Cc: jasowang@redhat.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash() Message-ID: <20220510012221-mutt-send-email-mst@kernel.org> References: <20220509131432.16568-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220509131432.16568-1-tangbin@cmss.chinamobile.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 09, 2022 at 09:14:32PM +0800, Tang Bin wrote: > In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included > in "default", so it canbe removed. > > Signed-off-by: Tang Bin What's the point of this? > --- > drivers/net/virtio_net.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 87838cbe3..b3e5d8637 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1172,7 +1172,6 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash, > case VIRTIO_NET_HASH_REPORT_IPv6_EX: > rss_hash_type = PKT_HASH_TYPE_L3; > break; > - case VIRTIO_NET_HASH_REPORT_NONE: > default: > rss_hash_type = PKT_HASH_TYPE_NONE; > } > -- > 2.20.1.windows.1 > >