Re: [PATCH v3 8/8] vfio/pci: Add the support for PCI D3cold state

Alex Williamson
2022-05-31T22:52:19Z

On Tue, 31 May 2022 16:43:04 -0300
Jason Gunthorpe <jgg@nvidia.com> wrote:

> On Tue, May 31, 2022 at 05:44:11PM +0530, Abhishek Sahu wrote:
> > On 5/30/2022 5:55 PM, Jason Gunthorpe wrote:
> > > On Mon, May 30, 2022 at 04:45:59PM +0530, Abhishek Sahu wrote:
> > >
> > >> 1. In real use case, config or any other ioctl should not come along
> > >> with VFIO_DEVICE_FEATURE_POWER_MANAGEMENT ioctl request.
> > >>
> > >> 2. Maintain some 'access_count' which will be incremented when we
> > >> do any config space access or ioctl.
> > >
> > > Please don't open code locks - if you need a lock then write a proper
> > > lock. You can use the 'try' variants to bail out in cases where that
> > > is appropriate.
> > >
> > > Jason
> >
> > Thanks Jason for providing your inputs.
> >
> > In that case, should I introduce new rw_semaphore (For example
> > power_lock) and move ‘platform_pm_engaged’ under ‘power_lock’ ?
>
> Possibly, this is better than an atomic at least
>
> > 1. At the beginning of config space access or ioctl, we can take the
> > lock
> >
> > down_read(&vdev->power_lock);
>
> You can also do down_read_trylock() here and bail out as you were
> suggesting with the atomic.
>
> trylock doesn't have lock odering rules because it can't sleep so it
> gives a bit more flexability when designing the lock ordering.
>
> Though userspace has to be able to tolerate the failure, or never make
> the request.
>
> > down_write(&vdev->power_lock);
> > ...
> > switch (vfio_pm.low_power_state) {
> > case VFIO_DEVICE_LOW_POWER_STATE_ENTER:
> > ...
> > vfio_pci_zap_and_down_write_memory_lock(vdev);
> > vdev->power_state_d3 = true;
> > up_write(&vdev->memory_lock);
> >
> > ...
> > up_write(&vdev->power_lock);
>
> And something checks the power lock before allowing the memor to be
> re-enabled?
>
> > 4. For ioctl access, as mentioned previously I need to add two
> > callbacks functions (one for start and one for end) in the struct
> > vfio_device_ops and call the same at start and end of ioctl from
> > vfio_device_fops_unl_ioctl().
>
> Not sure I followed this..

I'm kinda lost here too. A couple replies back there was some concern
about race scenarios with multiple user threads accessing the device.
The ones concerning non-deterministic behavior if a user is
concurrently changing power state and performing other accesses are a
non-issue, imo. I think our goal is only to expand the current
memory_lock to block accesses, including config space, while the device
is in low power, or some approximation bounded by the entry/exit ioctl.

I think the remaining issues is how to do that relative to the fact
that config space access can change the memory enable state and would
therefore need to upgrade the memory_lock read-lock to a write-lock.
For that I think we can simply drop the read-lock, acquire the
write-lock, and re-test the low power state. If it has changed, that
suggests the user has again raced changing power state with another
access and we can simply drop the lock and return -EIO.

If I'm still misunderstanding, please let me know. Thanks,

Alex