From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E044C433FE for ; Tue, 10 May 2022 15:43:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346146AbiEJPrt (ORCPT ); Tue, 10 May 2022 11:47:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346141AbiEJPrp (ORCPT ); Tue, 10 May 2022 11:47:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5E6227D01B; Tue, 10 May 2022 08:43:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4104261446; Tue, 10 May 2022 15:43:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0147C385C9; Tue, 10 May 2022 15:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652197424; bh=DkSAN+USaVISzIjayqT0awv2aj71/kgubBKemCRn9mw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XvRzvE4sHIaBqKhlknULILFkog9hAsdY0sk/QTXQ0DNe53/B8/ZpybUY68Ur5qZbt AJqdQB0ahggDGLQOj6Xp2MLne6lCNuGDW5Soy2UV9aPN/J1ciJjQT1goQG41wg+5QJ IcbhktXw/W6rsobZ0xD99su0sBZLzeF3VM526NcLs2GwONY4UHt8pdOpOVofLtyLkt LjQAbSiq2Xc7gUKL2twLc90BLD8RlSmrE3rjOMpHZYvLzi+B325DZNkt69LIozxOnu c+mjfdl63y4pCxFG26Xi63bAs2R7UMUqfM+MjJWf0cBvXJQfNzewZR0JDPIGtGMY3O MiXMS19i+NFmA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Ji-Ze Hong (Peter Hong)" , Ji-Ze Hong , Guenter Roeck , Sasha Levin , jdelvare@suse.com, linux-hwmon@vger.kernel.org Subject: [PATCH AUTOSEL 5.17 02/21] hwmon: (f71882fg) Fix negative temperature Date: Tue, 10 May 2022 11:43:21 -0400 Message-Id: <20220510154340.153400-2-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510154340.153400-1-sashal@kernel.org> References: <20220510154340.153400-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Ji-Ze Hong (Peter Hong)" [ Upstream commit 4aaaaf0f279836f06d3b9d0ffeec7a1e1a04ceef ] All temperature of Fintek superio hwmonitor that using 1-byte reg will use 2's complement. In show_temp() temp = data->temp[nr] * 1000; When data->temp[nr] read as 255, it indicate -1C, but this code will report 255C to userspace. It'll be ok when change to: temp = ((s8)data->temp[nr]) * 1000; Signed-off-by: Ji-Ze Hong (Peter Hong) Link: https://lore.kernel.org/r/20220418090706.6339-1-hpeter+linux_kernel@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/f71882fg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c index 938a8b9ec70d..6830e029995d 100644 --- a/drivers/hwmon/f71882fg.c +++ b/drivers/hwmon/f71882fg.c @@ -1578,8 +1578,9 @@ static ssize_t show_temp(struct device *dev, struct device_attribute *devattr, temp *= 125; if (sign) temp -= 128000; - } else - temp = data->temp[nr] * 1000; + } else { + temp = ((s8)data->temp[nr]) * 1000; + } return sprintf(buf, "%d\n", temp); } -- 2.35.1