From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF80C433EF for ; Thu, 12 May 2022 13:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354755AbiELNya (ORCPT ); Thu, 12 May 2022 09:54:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354548AbiELNyY (ORCPT ); Thu, 12 May 2022 09:54:24 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E09D71A72BF; Thu, 12 May 2022 06:54:22 -0700 (PDT) X-UUID: 3deb567847184581bf803389edc31ea8-20220512 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:c2229863-19f2-4524-9f1a-722db91ab9dc,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:faefae9,CLOUDID:42e4fdf1-ab23-4aed-a67b-f96514452486,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:-5,EDM:-3,File:nil,QS:0,BEC:ni l X-UUID: 3deb567847184581bf803389edc31ea8-20220512 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1740765071; Thu, 12 May 2022 21:54:17 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 12 May 2022 21:54:17 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 12 May 2022 21:54:16 +0800 From: Miles Chen To: CC: , , , , , , , , , , Subject: Re: [PATCH v2 02/11] clk: mediatek: apmixed: Drop error message from clk_register() failure Date: Thu, 12 May 2022 21:54:17 +0800 Message-ID: <20220512135417.4399-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220510104804.544597-3-wenst@chromium.org> References: <20220510104804.544597-3-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > mtk_clk_register_ref2usb_tx() prints an error message if clk_register() > fails. It doesn't if kzalloc() fails though. The caller would then tack > on its own error message to handle this. > > Also, All other clk registration functions in the MediaTek clk library > leave the error message printing to the bulk registration functions, > while the helpers that register individual clks just return error codes. > > Drop the error message that is printed when clk_register() fails in > mtk_clk_register_ref2usb_tx() to make its behavior consistent both > across its failure modes, and with the rest of the driver library. > > Signed-off-by: Chen-Yu Tsai Reviewed-by: Miles Chen