From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDB2C433FE for ; Thu, 12 May 2022 14:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355437AbiELOjL (ORCPT ); Thu, 12 May 2022 10:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355071AbiELOjJ (ORCPT ); Thu, 12 May 2022 10:39:09 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C751B253AAC for ; Thu, 12 May 2022 07:39:08 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id qe3-20020a17090b4f8300b001dc24e4da73so5943177pjb.1 for ; Thu, 12 May 2022 07:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RpvA14mopi2wM/0/4s7P6t9yjcv8sVd/ys9twTz6XHs=; b=IwjrKmELqe++qDbcjrB0VrUfg6crocNU1xe5lMxp6nWDAzOL5RWRRt8saVMkiGySTi oFhpr/l7d61NIYvJG9xPdiXKeej6OyIZFHq7456kaCwqyz0g5bKVMdETsAH1TBVFFayr rlNG/yc6J6myUNMWB6CFQ8qjTTUSzLwGSQTawUMIPH1LQ1wIQ39pAcWNRk4Wy4HpF9Q5 1GqUU7aWjlfmKZtqOwn+axFPpEsVq+5jqEMW2ZvjYj4y421WNHqCgfnk7QPDI/12rh7C QNy2f3yAt3shWmOImGNjA8N37MhIMQs0iwYguP2rDjiZtaWS4/AE0VDsyJqe0dlJnArm Ptvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RpvA14mopi2wM/0/4s7P6t9yjcv8sVd/ys9twTz6XHs=; b=j7YlehX6PE/L//NNMlztHY63UMqzR+11B/wwQoFvcuD8lGa8+t17Dq9yvAX5XxU3re 6Xu9lEfbBl8Dqy8G/k7+bsdC9WwkiYicQyB347qDXyGjuMa01kAEXRVZmbCsxQqJpo6t uQvspjExtZjoGAujW7Q7fUrjhEfEjkFhGeIRWJIkdXP91upuh1MfpE3U/5+n3WeQDAGH PAc6FqETjjLs2K503i4GqNNbzEGyH40XQiPVUC+D1ARrikPD94Xe7ZH+su027jdYV1AZ CtFIr/gA1UG7OzrelDZnAvHyL89u9mfwOvJ6ucZ0cmW5yrMrIRdCUYmx31hfvu/2B16i mnPg== X-Gm-Message-State: AOAM5309Dn4C8Z/95oPDPwSYrm5hwmop/wqbfpl0C3yLUYRmOXMtId7Z bWecuUd5z58Mkq3ygX+bomMN X-Google-Smtp-Source: ABdhPJzGX4QVR+Nu2JITJr/b8RNE+XCcktTJ7Bx+sADcWNFJ0GnMQN2f39XlXIhEaWDxYRZWAK1HHw== X-Received: by 2002:a17:902:f710:b0:15f:165f:b50b with SMTP id h16-20020a170902f71000b0015f165fb50bmr276822plo.158.1652366348217; Thu, 12 May 2022 07:39:08 -0700 (PDT) Received: from thinkpad ([117.202.184.202]) by smtp.gmail.com with ESMTPSA id 72-20020a62154b000000b0050dc762816bsm3852511pfv.69.2022.05.12.07.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 07:39:07 -0700 (PDT) Date: Thu, 12 May 2022 20:09:00 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Gustavo Pimentel , Vinod Koul , Jingoo Han , Bjorn Helgaas , Lorenzo Pieralisi , Frank Li , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/26] dmaengine: dw-edma: Release requested IRQs on failure Message-ID: <20220512143900.GH35848@thinkpad> References: <20220503225104.12108-1-Sergey.Semin@baikalelectronics.ru> <20220503225104.12108-4-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220503225104.12108-4-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 04, 2022 at 01:50:41AM +0300, Serge Semin wrote: > From very beginning of the DW eDMA driver live in the kernel the method > dw_edma_irq_request() hasn't been designed quite correct. In case if the > request_irq() method fails to initialize the IRQ handler at some point the > previously requested IRQs will be left initialized. It's prune to errors > up to the system crash. Let's fix that by releasing the previously > requested IRQs in the cleanup-on-error path of the dw_edma_irq_request() > function. > > Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") > Signed-off-by: Serge Semin Reviewed-by: Manivannan Sadhasivam Thanks, Mani > > --- > > Changelog v2: > - This is a new patch added in v2 iteration of the series. > --- > drivers/dma/dw-edma/dw-edma-core.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c > index 07f756479663..04efcb16d13d 100644 > --- a/drivers/dma/dw-edma/dw-edma-core.c > +++ b/drivers/dma/dw-edma/dw-edma-core.c > @@ -899,10 +899,8 @@ static int dw_edma_irq_request(struct dw_edma *dw, > dw_edma_interrupt_read, > IRQF_SHARED, dw->name, > &dw->irq[i]); > - if (err) { > - dw->nr_irqs = i; > - return err; > - } > + if (err) > + goto err_irq_free; > > if (irq_get_msi_desc(irq)) > get_cached_msi_msg(irq, &dw->irq[i].msi); > @@ -911,6 +909,14 @@ static int dw_edma_irq_request(struct dw_edma *dw, > dw->nr_irqs = i; > } > > + return 0; > + > +err_irq_free: > + for (i--; i >= 0; i--) { > + irq = chip->ops->irq_vector(dev, i); > + free_irq(irq, &dw->irq[i]); > + } > + > return err; > } > > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்