Re: [PATCH] dt-bindings: Renamed hte directory to timestamp

Rob Herring
2022-05-23T16:05:47Z

On Tue, May 17, 2022 at 7:35 PM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, 12 May 2022 10:50:11 -0700, Dipen Patel wrote:
> > Renamed hte dt binding directory to timestamp according review comment.
> > Addressed minor comment about having HTE acronym first in the common dt
> > binding document.
> >
> > The change reflects above renaming in MAINTAINERS files too.
> >
> > Signed-off-by: Dipen Patel <dipenp@nvidia.com>
> > ---
> > This patch is on top of old series (Intro to Hardware timestamping
> > engine V6) present in linux-next tentatively in preparation for
> > merge.
> >
> > .../{hte => timestamp}/hardware-timestamps-common.yaml | 6 +++---
> > .../bindings/{hte => timestamp}/hte-consumer.yaml | 0
> > .../bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml | 0
> > MAINTAINERS | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
> > rename Documentation/devicetree/bindings/{hte => timestamp}/hardware-timestamps-common.yaml (71%)
> > rename Documentation/devicetree/bindings/{hte => timestamp}/hte-consumer.yaml (100%)
> > rename Documentation/devicetree/bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml (100%)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>

I take that back:

./Documentation/devicetree/bindings/timestamp/hte-consumer.yaml: $id:
relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
./Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
./Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#

I was wondering why a new common binding was already in next without a
Reviewed-by, but I let that slide. Now I regret doing that.

Rob