Re: [RFC PATCH v2 14/21] treewide: Drop __cficanonical

Kees Cook
2022-05-14T21:58:00Z

On Fri, May 13, 2022 at 01:21:52PM -0700, Sami Tolvanen wrote:
> CONFIG_CFI_CLANG doesn't use a jump table anymore and therefore,
> won't change function references to point elsewhere. Remove the
> __cficanonical attribute and all uses of it.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
> ---
> include/linux/compiler_types.h | 4 ----
> include/linux/init.h | 4 ++--
> include/linux/pci.h | 4 ++--
> 3 files changed, 4 insertions(+), 8 deletions(-)

I think this is missing removing it from include/linux/compiler-clang.h ?

With that done (or explained why not):

Reviewed-by: Kees Cook <keescook@chromium.org>

--
Kees Cook