From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C6EC433F5 for ; Sat, 14 May 2022 21:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230083AbiENV6W (ORCPT ); Sat, 14 May 2022 17:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235576AbiENV6L (ORCPT ); Sat, 14 May 2022 17:58:11 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B42F340E62 for ; Sat, 14 May 2022 14:58:08 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id j6so10712367pfe.13 for ; Sat, 14 May 2022 14:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F4n+C6M9Aw1zMVfcPORGXMMVLEr2xX50zcVOAMomtNI=; b=ORcydA/uFIOR4odJFAV1XxY+PcGt2zebDpivlroBUEMd4PMs7KqLIIwFyrSrx1hQve IphjhRek3rFH0b0wKiFSafB46D14B6zsDaIUkgdWyUVQ4HxGNE+LGPeFItDUMmv7WDWQ l82UrDZKj39Vo1sdMxdDyg2ceu7AxyeuoD9GA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F4n+C6M9Aw1zMVfcPORGXMMVLEr2xX50zcVOAMomtNI=; b=NJnlUK6uRwGwaUKx22CpIRW9MkrIkoq088vVyI7vdlRmq01tsQeAeffFVBOPIfwYO1 lQAwtAQkJu3yZFsOPAJ0oapWcvthZQqsvBcM8MAFnnOgmIIIjQjCM+Prt5FQuP4KV4TK yaOb3NlMVSH3jMYJsUxnOQR8mHknOEyhaP7jiQ9OTXW5NlB59L9UX33XCTF0+882FEf/ 7eXosI9KdubGYXB4C7P/WAVhoToMTG1lLoRcvue2jyRIfjdfxrnNh9hS4xFy6n8x1jOE vJDYT2KmTZ1qpDdMrN4riKPiF6JLzJxu1Pe+UAN0b7ioUQaJ5FX473GAbXQl0yhWf3r4 Lb6A== X-Gm-Message-State: AOAM531VDBMn1miuGqzrMpNYIKp/pMwmAmxqQG7a0UwBVmoOcp16P4ZS 9VhgZM6XfvILNAqcno1AhzjFeQ== X-Google-Smtp-Source: ABdhPJwOtndnmF6wotSc9dg7+c73fyG5+SBhQYVy5w8DsKeAwdpvOT6FhYjPgzOsGs5Q1NOcr1h40Q== X-Received: by 2002:a63:190f:0:b0:3db:972b:46bb with SMTP id z15-20020a63190f000000b003db972b46bbmr7949134pgl.554.1652565488145; Sat, 14 May 2022 14:58:08 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o14-20020a655bce000000b003db8dd388afsm3840321pgr.10.2022.05.14.14.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:58:07 -0700 (PDT) Date: Sat, 14 May 2022 14:58:07 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 17/21] x86: Add types to indirectly called assembly functions Message-ID: <202205141458.80233E7ED@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-18-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220513202159.1550547-18-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2022 at 01:21:55PM -0700, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, assembly functions indirectly called from C code > must be annotated with type identifiers to pass CFI checking. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook