From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
<richard@nod.at>, <vigneshr@ti.com>
Subject: Re: [PATCH -next] mtd: st_spi_fsm: add missing clk_disable_unprepare() stfsm_remove()
Date: Mon, 16 May 2022 09:51:08 +0200 [thread overview]
Message-ID: <20220516095108.4ec6d0d9@xps13> (raw)
In-Reply-To: <0d7ee262-6286-ec41-884e-3ab5863b68b4@huawei.com>
Hello,
yangyingliang@huawei.com wrote on Sat, 14 May 2022 10:12:55 +0800:
> Hi,
>
> On 2022/5/13 18:22, Miquel Raynal wrote:
> > Hi,
> >
> > yangyingliang@huawei.com wrote on Fri, 13 May 2022 18:03:22 +0800:
> >
> >> Clock source is prepared and enabled by clk_prepare_enable()
> >> in probe function, but no disable or unprepare in remove function.
> > not disabled or unprepared
> >
> > Otherwise looks good.
> Do I need to resend it ?
Yes, please.
Thanks,
Miquèl
prev parent reply other threads:[~2022-05-16 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 10:03 [PATCH -next] mtd: st_spi_fsm: add missing clk_disable_unprepare() stfsm_remove() Yang Yingliang
2022-05-13 10:22 ` Miquel Raynal
2022-05-14 2:12 ` Yang Yingliang
2022-05-16 7:51 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516095108.4ec6d0d9@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox