Re: [PATCH v1 02/17] Revert "ARM: dts: imx6qdl-apalis: Avoid underscore in node name"

Rob Herring
2022-05-18T19:01:49Z

On Mon, May 16, 2022 at 01:58:30PM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> The STMPE MFD device binding requires the child node to have a fixed
> name, i.e. with '_', not '-'. Otherwise the stmpe_adc, stmpe_touchscreen
> drivers will not be probed.
>
> Fixes: 56086b5e804f ("ARM: dts: imx6qdl-apalis: Avoid underscore in node name")
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> ---
>
> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index bd763bae596b..da919d0544a8 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -315,7 +315,7 @@
> /* ADC conversion time: 80 clocks */
> st,sample-time = <4>;
>
> - stmpe_touchscreen: stmpe-touchscreen {
> + stmpe_touchscreen: stmpe_touchscreen {

In any case, the correct name would have been 'touchscreen' and 'adc'.

> compatible = "st,stmpe-ts";
> /* 8 sample average control */
> st,ave-ctrl = <3>;
> @@ -332,7 +332,7 @@
> st,touch-det-delay = <5>;
> };
>
> - stmpe_adc: stmpe-adc {
> + stmpe_adc: stmpe_adc {
> compatible = "st,stmpe-adc";
> /* forbid to use ADC channels 3-0 (touch) */
> st,norequest-mask = <0x0F>;
> --
> 2.20.1
>