From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1674DC433F5 for ; Mon, 16 May 2022 23:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347496AbiEPXCE (ORCPT ); Mon, 16 May 2022 19:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240212AbiEPXCB (ORCPT ); Mon, 16 May 2022 19:02:01 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08D5F2AFF for ; Mon, 16 May 2022 16:01:58 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id bo5so15356219pfb.4 for ; Mon, 16 May 2022 16:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lGx5OaF/nNf+wAk/UXSTp7o/h1yC5nC+cmEZ08o7IyE=; b=H6Efosz+U4jL2Q/PRaySKd7X1SckPh/0vK1RwkUKGINiTgldM9LZ6aaqeeIxLJrjyA 0TyW5rImHO2dZuioVDvS5m2xiA38/mzt0eoPEITqOTx40PddhxtCCtpekYSjT4Dt5eQT prIv07wrhhjPwKg9g1h+ACZL2KBo8DGGfraR4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lGx5OaF/nNf+wAk/UXSTp7o/h1yC5nC+cmEZ08o7IyE=; b=f+avSYjy2552JQ7xSjPNTiYYIz2zFqBYrc2fhuFVkxCFvL8OdDr7t7DB257uf56G79 4lcVNnzwi4lGg1wEubaWq+G2iwwnFy3tirS7JDwQEvXU6ign62gNSowQuJscIWCQDATJ 3C1cVNed3P1IycNuW3vIP14I6ybXIatEvetrDU6Nhsd8pNmsJfnPbERoqo5mFWQcG9BJ 6YYD6SKYHAYSZw1kKuIVYkOy66sGBNXmC3v2Unw0I9dzqYG9Py5iOwfji0UVMNDAzP6v 1bP9O0SRb6xP51KXx+QVn9THxoI/JCPdITHOYX/t5rsGUYVvVs6rui0w81AvzjU9Blvc mhCw== X-Gm-Message-State: AOAM53340aYDeJVK2a63HGMvns2V+INpyRKb5GIvRralfSZxLeyyYrAM 9w2rpp4ouzvkrA5bWgZXKQM9Fg== X-Google-Smtp-Source: ABdhPJxko9JuM1KI2cl8VriIGs+4kOv8T8gQAgbApOgjucLuTCSJVO9OOecJiH06QAjAJNiIJdWiqA== X-Received: by 2002:a05:6a00:174f:b0:4fd:aed5:b5e4 with SMTP id j15-20020a056a00174f00b004fdaed5b5e4mr19751789pfc.39.1652742118486; Mon, 16 May 2022 16:01:58 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r8-20020a170902ea4800b001618f5186f1sm1908968plg.80.2022.05.16.16.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 16:01:58 -0700 (PDT) Date: Mon, 16 May 2022 16:01:57 -0700 From: Kees Cook To: Nick Desaulniers Cc: Nathan Chancellor , kernel test robot , Rasmus Villemoes , Vitor Massaru Iha , "Gustavo A. R. Silva" , Daniel Latypov , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] lib: overflow: Always build 64-bit test cases Message-ID: <202205161601.14C4F8DF@keescook> References: <20220511174531.1098548-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2022 at 02:35:45PM -0700, Nick Desaulniers wrote: > On Wed, May 11, 2022 at 10:45 AM Kees Cook wrote: > > > > There shouldn't be a reason to not build the 64-bit test cases on 32-bit > > systems; the types exist there too. Remove the #ifdefs. > > I think this is breaking 32b ARM for clang-13 and older? > https://github.com/ClangBuiltLinux/linux/issues/1636 Ah-ha, that's the combo I hadn't found. Thank you! -- Kees Cook