From: Stephen Boyd <sboyd@kernel.org>
To: Codrin.Ciubotariu@microchip.com,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: mturquette@baylibre.com, Nicolas.Ferre@microchip.com,
alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com
Subject: Re: [PATCH] clk: at91: generated: consider range when calculating best rate
Date: Tue, 17 May 2022 00:14:38 -0700 [thread overview]
Message-ID: <20220517071440.DAC76C385B8@smtp.kernel.org> (raw)
In-Reply-To: <e18eb810-e437-6a19-26ec-1f0daedaaf5f@microchip.com>
Quoting Codrin.Ciubotariu@microchip.com (2022-04-26 00:24:15)
> On 22.04.2022 04:12, Stephen Boyd wrote:
> > Quoting Codrin Ciubotariu (2022-04-13 00:13:18)
> >> clk_generated_best_diff() helps in finding the parent and the divisor to
> >> compute a rate closest to the required one. However, it doesn't take into
> >> account the request's range for the new rate. Make sure the new rate
> >> is within the required range.
> >>
> >> Fixes: 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")
> >> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> >> ---
> >
> > Is this fixing anything real or it's just a thing that you noticed and
> > sent a patch to fix?
>
> It fixes the clk_set_min/max_rate() calls to a generated clock. Do you
> want me to add this fact in the commit description?
>
I wanted to know if there are clk_set_min/max_rate() calls on this clk.
Are there?
next prev parent reply other threads:[~2022-05-17 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 7:13 [PATCH] clk: at91: generated: consider range when calculating best rate Codrin Ciubotariu
2022-04-13 7:54 ` Claudiu.Beznea
2022-04-22 1:12 ` Stephen Boyd
2022-04-26 7:24 ` Codrin.Ciubotariu
2022-05-17 7:14 ` Stephen Boyd [this message]
2022-05-17 8:04 ` Codrin.Ciubotariu
2022-05-17 19:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517071440.DAC76C385B8@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox